[Translation] check empty notes

[davidvancl]

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	--
License	MIT

In the case of notes, an empty array is always stored in the metadata. The is_iterable condition always returns true even if notes is empty and there is no location info. When notes are loaded within a translation, translations containing will crash.

[carsonbot]

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

[OskarStark]

Does this also apply to 6.4?

Please add a testcase

[welcoMattic]

Thank you @davidvancl.
Could you take care of what fabbot reported? And be sure that failing tests are not related to your modifications?

[davidvancl]

I added a test for empty notes, I don't know why all the tests failed. When I run them locally they pass. Could it be somehow related to CI? also fixed the syntax that was reporting fabbot. @welcoMattic Thank you.

[nicolas-grekas]

Thank you @davidvancl.

[Hanmac]

@nicolas-grekas now my tests are failing:

-   <unit id="Ll7LrI6" name="empty">\n
+    <unit id="Lhz6grA" name="empty">\n