Skip to content

Fix instantiating LiveComponentMetadata multiple times #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix instantiating LiveComponentMetadata multiple times #1251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/LiveComponent/src/Metadata/LiveComponentMetadataFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
*/
class LiveComponentMetadataFactory
{
/** @var LiveComponentMetadata[] */
private array $liveComponentMetadata = [];

public function __construct(
private ComponentFactory $componentFactory,
private PropertyTypeExtractorInterface $propertyTypeExtractor,
Expand All @@ -33,12 +36,16 @@ public function __construct(

public function getMetadata(string $name): LiveComponentMetadata
{
if (isset($this->liveComponentMetadata[$name])) {
return $this->liveComponentMetadata[$name];
}

$componentMetadata = $this->componentFactory->metadataFor($name);

$reflectionClass = new \ReflectionClass($componentMetadata->getClass());
$livePropsMetadata = $this->createPropMetadatas($reflectionClass);

return new LiveComponentMetadata($componentMetadata, $livePropsMetadata);
return $this->liveComponentMetadata[$name] = new LiveComponentMetadata($componentMetadata, $livePropsMetadata);
}

/**
Expand Down