Skip to content

[Translator] Fix CS on TranslatorCompilerPass #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Translator] Fix CS on TranslatorCompilerPass #1996

merged 1 commit into from
Jul 23, 2024

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jul 19, 2024

Q A
Bug fix? yes/no
New feature? yes/no
Issues Fix #...
License MIT

@carsonbot carsonbot added Bug Bug Fix Feature New Feature Status: Needs Review Needs to be reviewed labels Jul 19, 2024
@Kocal Kocal requested review from kbond and smnandre July 19, 2024 06:19
@Kocal Kocal mentioned this pull request Jul 19, 2024
Merged
smnandre
smnandre approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jul 19, 2024
@javiereguiluz
Copy link
Member

Thanks Hugo.

@javiereguiluz javiereguiluz merged commit 99b6359 into symfony:2.x Jul 23, 2024
35 checks passed
@Kocal Kocal deleted the fix/translator-cs branch July 23, 2024 16:14
@Kocal Kocal mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

@kbond kbond Awaiting requested review from kbond

Assignees
No one assigned
Labels
Bug Bug Fix Feature New Feature Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kocal @javiereguiluz @smnandre @carsonbot