Skip to content

Update naming of stimulus controller on default attributes - index.rst #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

DennisdeBest
Copy link
Contributor

To add a custom stimulus controller to the root component element the name can not contain -controller.

If using some_custom_controller.js, the name should be some-custom

I had some issues with that and figured it out on this github issue : #687 (comment)

Q A
Bug fix? no
New feature? no
License MIT

To add a custom stimulus controller to the root component element the name can not contain `-controller`.

If using `some_custom_controller.js`, the name should be `some-custom`

I had some issues with that and figured it out on this github issue : symfony#687 (comment)
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 11, 2024
@DennisdeBest DennisdeBest changed the title Update index.rst Update naming of stimulus controller on default attributes - index.rst Aug 11, 2024
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 11, 2024
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DennisdeBest!

@kbond
Copy link
Member

kbond commented Aug 13, 2024

Thank you Dennis.

@kbond kbond merged commit 4340c81 into symfony:2.x Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants