-
-
Notifications
You must be signed in to change notification settings - Fork 354
[DX] Add per-package Yarn scripts (build, watch, test, lint, ...) #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
commented
Nov 2, 2024
Kocal
commented
Nov 2, 2024
Kocal
commented
Nov 2, 2024
src/LiveComponent/assets/dist/Component/plugins/QueryStringPluging.d.ts
Outdated
Show resolved
Hide resolved
acab864
to
750de7d
Compare
Kocal
commented
Nov 2, 2024
Kocal
commented
Nov 2, 2024
6ca2c64
to
a850401
Compare
smnandre
reviewed
Nov 2, 2024
…rkspace, since Biome is super fast (also include bin and test JS files)
smnandre
reviewed
Nov 2, 2024
This is so grea! And it does run very quickly! Congrats and thank you 🙇 |
smnandre
approved these changes
Nov 2, 2024
7ec5095
to
b8dc5fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working in UX Map, it was very painful to build or watch modifications on
.ts
files, I had investigate how the building process worked, and had to run Rollup like this, which is far from ideal (not documented and not obvious):And I also felt sorry for @rrr63 when he worked on adding Polygons on Map (#2162)...
This PR improves the way developers will work on UX, and makes their lives easier.
Before:
yarn build
compiled the assets from ALL packages, it was not possible to build packages from only one package (which is useful if you work on a single package)yarn watch
yarn test
runned tests from ALL packages, likeyarn build
, it was not possible to run tests for only one packageNow:
build
/test
/lint
/format
/check-lint
/check-format
scripts will run on all assets from all packages. And it will be faster than before, when processing was sequential, but now it's parallelized.src/Map/assets
),build
/test
/lint
/format
/check-lint
/check-format
scripts will run on all assets from this package onlybuild
andwatch
scripts handles both TypeScript and CSS files in a single commandThis is a first step to what we spoke about with @smnandre to write a contribution guide.
It is now much more easier and friendlier to tell a developer to run
yarn watch
inside a package root, instead of telling it to run./node_modules/.bin/rollup -c --environment INPUT_FILE:src/Map/src/Bridge/Google/assets/src/map_controller.ts -w
(and more, if you have multiple files).