Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] Fetch icons in batch in Import command #2352

Merged
merged 1 commit into from
Nov 10, 2024
Merged

[Icons] Fetch icons in batch in Import command #2352

merged 1 commit into from
Nov 10, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Nov 8, 2024 •
edited
Loading

Q A
Bug fix? no
New feature? yes
Issues Fix #...
License MIT

First usage of #2351 with the import command

Update:

  • add icons counts (imported / total)
  • handle same-prefix icons per batch
  • improve visual feedback
Capture d’écran 2024-11-09 à 19 26 16

Next ones:

  • lock
  • warm-up

@smnandre smnandre requested review from kbond and Kocal November 8, 2024 02:23
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed Feature New Feature Icons labels Nov 8, 2024
@Kocal Kocal mentioned this pull request Nov 8, 2024
Merged
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 8, 2024
@smnandre smnandre requested a review from Kocal November 9, 2024 18:46
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Reviewed Has been reviewed by a maintainer labels Nov 9, 2024
@smnandre smnandre requested a review from kbond November 9, 2024 18:46
@smnandre smnandre merged commit 3a1ae4e into symfony:2.x Nov 10, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@Kocal Kocal Awaiting requested review from Kocal

@kbond kbond Awaiting requested review from kbond

Assignees
No one assigned
Labels
Feature New Feature Icons Performance Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smnandre @javiereguiluz @kbond @Kocal @carsonbot