Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Drop explicit Yarn dependencies caching steps for actions/setup-node #2504

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jan 13, 2025

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

While working on the UX's CI, I noticed that we manually handle Yarn cache (2 longs steps).

Instead, we can use actions/setup-node and cache: yarn to lighten the workflow file and ease the maintenance.

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Jan 13, 2025
@Kocal Kocal requested review from kbond, smnandre and WebMamba January 14, 2025 08:16
Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Jan 14, 2025
@Kocal Kocal merged commit b4b3ff3 into symfony:2.x Jan 14, 2025
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants