Skip to content

fix missing }, reformat so it's visible #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix missing }, reformat so it's visible #2599

merged 1 commit into from
Feb 24, 2025

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Feb 24, 2025

<div {{ stimulus_controller('chart',
            { 'name': 'Likes', 'data': [1, 2, 3, 4] }, 
            { 'loading': 'spinner' }, 
            { 'other': '.target' } ) }}>

Currently, the 'outlet' part is cut off:

image

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Feb 24, 2025
@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Feb 24, 2025
@Kocal Kocal added docs Improvements or additions to documentation and removed Status: Reviewed Has been reviewed by a maintainer labels Feb 24, 2025
Hello
</div>


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

```twig
<div {{ stimulus_controller('chart',
            { 'name': 'Likes', 'data': [1, 2, 3, 4] },
            { 'loading': 'spinner' },
            { 'other': '.target' } ) }}>
```
@Kocal
Copy link
Member

Kocal commented Feb 24, 2025

Thank you @tacman.

@Kocal Kocal merged commit 80788f7 into symfony:2.x Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants