Skip to content

Drop Symfony PHPUnit bridge for PHPUnit on UX packages PHP >= 8.3 #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Mar 25, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

Inspired from symfony/demo@7f57f38#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Mar 25, 2025
@Kocal Kocal marked this pull request as draft March 25, 2025 22:23
@Kocal Kocal force-pushed the drop-phpunit-bridge-for-phpunit branch 6 times, most recently from 4f859e8 to 8aa6585 Compare March 25, 2025 23:34
@Kocal
Copy link
Member Author

Kocal commented Mar 26, 2025

Well, that's too early.

On some UX packages depending on PHP 8.1+, we need to require PHPUnit 10 but we can't configure Symfony's PHPUnit Bridge SymfonyTestsListener and we don't have access to $this->expectUserDeprecationMessage() which is introduced in PHPUnit 11 (PHP 8.2+), making us impossible to expect deprecations.
Thus, we can't migrate to raw PHPUnit on these packages.

Symfony's PHPUnit Bridge can only be removed on UX packages depending on PHP 8.3+ (only Map and its Bridge)

@Kocal Kocal force-pushed the drop-phpunit-bridge-for-phpunit branch 3 times, most recently from 720ae73 to 8ec8cfc Compare March 26, 2025 07:20
@Kocal Kocal changed the title Drop Symfony PHPUnit bridge for PHPUnit Drop Symfony PHPUnit bridge for PHPUnit on UX packages PHP >= 8.3 Mar 26, 2025
@Kocal Kocal force-pushed the drop-phpunit-bridge-for-phpunit branch 6 times, most recently from b887fce to 85574a1 Compare March 26, 2025 08:45
@Kocal Kocal force-pushed the drop-phpunit-bridge-for-phpunit branch from 85574a1 to 770ae82 Compare March 26, 2025 08:46
@Kocal
Copy link
Member Author

Kocal commented Mar 26, 2025

Well, IDK what's happening with PHPUnit on Map packages, but it's now impossible to run tests, it takes ~3min30 instead of ~700ms, and it's impossible to debug with Blackfire ... 😓

➜  Map git:(drop-phpunit-bridge-for-phpunit) ✗ sfp vendor/bin/phpunit tests/UXMapBundleTest.php   
PHPUnit 12.1-dev by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.19
Configuration: /Users/kocal/workspace-os/symfony-ux/src/Map/phpunit.xml.dist

DD                                                                  2 / 2 (100%)

Time: 03:28.655, Memory: 92.02 MB

OK, but there were issues!
Tests: 2, Assertions: 2, Deprecations: 1.

I'm bored, let's retry another time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants