-
-
Notifications
You must be signed in to change notification settings - Fork 356
[WIP] LiveUrl #2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
[WIP] LiveUrl #2673
Conversation
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
(Had a quick chat with @mbuliard yesterday — he's making a few adjustments before opening the PR. Stay tuned! 😄 ) |
93c0a12
to
d848b54
Compare
@@ -328,6 +329,10 @@ export default class Component { | |||
} | |||
|
|||
this.processRerender(html, backendResponse); | |||
const liveUrl = await backendResponse.getLiveUrl(); | |||
if (liveUrl) { | |||
HistoryStrategy.replace(new UrlUtils(liveUrl + window.location.hash, window.location.origin)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HistoryStrategy.replace(new UrlUtils(liveUrl + window.location.hash, window.location.origin)); | |
history.replaceState(history.state, '', liveUrl + window.location.hash); |
? (not sure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would allow the remove both queryStringPlugin.ts and url_utils.ts (i think)
Do you want/need any help here @mbuliard ? |
ff471f9
to
6903e06
Compare
… props also from path. RequestInitializeSubscriber also renamed
Thanks ! I needed free time, but the PR is almost done. Related tests are green, but I shall now add my own testing of the backend. What took me some time was to the handling of custom actions, who may (and often do) update component props. I choose to store the updated component props in |
WIP, do not merge