Skip to content

[Map] Fix 2.23/2.24 changelog #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

zak39
Copy link
Contributor

@zak39 zak39 commented Apr 1, 2025

Q A
Bug fix? no
New feature? no
Docs? yes
Issues Chore
License MIT

The following features were removed from the changelog as they are not present in the 2.23 release:

  • id to Marker, Polygon and Polyline constructors
  • Map::removeMarker(string|Marker $markerOrId)
  • Map::removePolygon(string|Polygon $polygonOrId)
  • Map::removePolyline(string|Polyline $polylineOrId)

@zak39 zak39 requested a review from Kocal as a code owner April 1, 2025 21:02
@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Apr 1, 2025
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lines you removed must be moved to 2.24, as the features are still present in the repository

@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Apr 1, 2025
@Kocal Kocal changed the title Chore: Remove features no present in the 2.23 release from changelog [Map] Fix 2.23/2.24 changelog Apr 1, 2025
The following features were moved in the changelog as they are not present in the 2.23 release, but will be included in the 2.24 release

-  `id` to `Marker`, `Polygon` and `Polyline` constructors
-  `Map::removeMarker(string|Marker $markerOrId)`
-  `Map::removePolygon(string|Polygon $polygonOrId)`
-  `Map::removePolyline(string|Polyline $polylineOrId)`
@zak39 zak39 force-pushed the chore/remove-features-no-presents branch from 50ffc4b to b8d745c Compare April 1, 2025 21:45
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Apr 1, 2025
@zak39
Copy link
Contributor Author

zak39 commented Apr 1, 2025

I fixed it, I apologize for my mistake 🙏

@Kocal Kocal added the Map label Apr 1, 2025
@Kocal
Copy link
Member

Kocal commented Apr 1, 2025

Don't worry, mistake happens ✨

image

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Apr 1, 2025
@Kocal
Copy link
Member

Kocal commented Apr 1, 2025

Thank you @zak39.

@Kocal Kocal merged commit 2a6c2dc into symfony:2.x Apr 1, 2025
1 check passed
@zak39
Copy link
Contributor Author

zak39 commented Apr 2, 2025

Thank you @zak39.

You're welcome ! 😉

@zak39 zak39 deleted the chore/remove-features-no-presents branch April 2, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants