[LiveComponent] Release the loading state before any redirect. #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukei
changed the title
📊 Packages dist files size differenceℹ️ No difference in dist packagesFiles. |
smnandre
reviewed
Apr 13, 2025
Comment on lines
+2155
to
2158
| this.hooks.triggerHook('loading.state:finished', this.element); | ||
| if (backendResponse.response.headers.get('Location')) { | ||
| if (this.isTurboEnabled()) { | ||
| Turbo.visit(backendResponse.response.headers.get('Location')); |
There was a problem hiding this comment.
I'm not sure we want to trigger the "finished" event before Turbo does its work.
Here you could do something just before the
window.location.href = backendResponse.response.headers.get('Location') || '';There was a problem hiding this comment.
I use Turbo on this project and I need it to be triggered in that setup too. BTW, I'm actualy using this patch and it didn't seems to create any issues.
EDIT : I disabled Turbo in that case to avoid a double fetch of the URL, that may be the reason I didn't have any issue. So WDYT? Should I move the call?
Kocal
added
Status: Waiting Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempt to release the loading state before redirecting the user. This one may seems a little weird at first, but it has its use case.
I just write an export feature that uses a LiveComponent action to build a file. While the export is made, the UI add some classes and/or attributes to convey the "in progress" meaning. When it's done, the user is redirected to a specific controller that initiate the download. Since the redirected page just provide a file attachment, the user stay on the original page (fully expected). But, at this stage, the loading state is never released. By releasing the loading state before the redirect, the UI is made responsive again.