Apply fabbot rules #2957
Merged
Apply fabbot rules #2957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jul 29, 2025
nicolas-grekas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Docs? | no |
| Issues | - |
| License | MIT |
- no-void to test cases
- typos
- tweaks to exception messages
Member
Author
|
(fabbot's failures are false-positive typos.) |
Member
|
For Turbo, we will need to configure PHPStan to ignore |
Kocal
reviewed
Jul 29, 2025
nicolas-grekas
force-pushed
the
cs
branch
2 times, most recently
from
03365f4 to
a08a810
Compare
Member
Author
done! |
Kocal
approved these changes
Jul 29, 2025
Member
Kocal
left a comment
Kocal
left a comment
There was a problem hiding this comment.
Thanks!
Don't worry about PHP 8.4 & Windows failing checks, there are known issues and unrelated to your PR
carsonbot
added
Status: Reviewed
Member
|
Pretty happy with codespell's corrections |
Member
|
Thank you @nicolas-grekas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.