Skip to content

[Live] Support (de)hydrating nullable backed Enum's #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2022
Merged

[Live] Support (de)hydrating nullable backed Enum's #416

merged 1 commit into from
Aug 11, 2022

Conversation

@kbond
Copy link
Member

@kbond kbond commented Aug 9, 2022

Q A
Bug fix? yes
New feature? no
Tickets Fix #414
License MIT

@kbond kbond mentioned this pull request Aug 9, 2022
Closed
@kbond kbond force-pushed the live-enum-support branch from e34deef to e05cd38 Compare August 9, 2022 20:32
@kbond kbond force-pushed the live-enum-support branch from e05cd38 to bfd7f8d Compare August 10, 2022 17:16
weaverryan
weaverryan reviewed Aug 11, 2022
View reviewed changes
src/LiveComponent/src/LiveComponentHydrator.php
$value = $component->$method($dehydratedValue);
} elseif ($property->getType() instanceof \ReflectionNamedType && !$property->getType()->isBuiltin()) {
$value = $this->normalizer->denormalize($value, $property->getType()->getName(), 'json', [self::LIVE_CONTEXT => true]);
} elseif (!$value && $type && $type->allowsNull() && is_a($type->getName(), \BackedEnum::class, true) && !\in_array($value, array_map(fn (\BackedEnum $e) => $e->value, $type->getName()::cases()))) {
Copy link
Member

@weaverryan weaverryan Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit specific or heavy-handed, as we discussed. But I think we should do it... if nothing else to see if this fixes things or helps us discover more use-cases so we can get this just right.

@weaverryan
Copy link
Member

weaverryan commented Aug 11, 2022

Thanks Kevin!

@weaverryan weaverryan merged commit 5893aca into symfony:2.x Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weaverryan weaverryan weaverryan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[LiveComponent] Incorrect handling of nullable enum types

2 participants

@kbond @weaverryan