-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Live] add test helper #823
Conversation
Again, with the system I describe in #818 (comment), we could make a really nice chainable test experience: $this->createLiveComponent('my_component')
->assertSeeIn('div.count', 1)
->call('increase')
->assertSeeIn('div.count', 2)
->call('increase', ['amount' => 3])
->assertSeeIn('div.count', 5)
; |
Hey @kbond, I am using this PR a lot to test my component and it's working great! Do you need a hand in order to finish it? |
I was really just waiting for this feedback! Think it's current state is enough to start? |
f9892d9
to
4b06ebd
Compare
4b06ebd
to
4e22914
Compare
I guess, I mean I didn't have a complex need yet but for my current need, it's working perfectly fine. |
Ok, I'll add |
eb6012f
to
04cff46
Compare
Ok, I believe this to be ready! I also added 586a572 but can move to another PR if desired. |
58ba8a5
to
faa1518
Compare
Thank you Kevin! |
This PR was merged into the 2.x branch. Discussion ---------- fix(live): fix testing events | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | Fix #1110 | License | MIT When implementing #823, I made the wrong assumption that events were identical to actions. This fixes that. Commits ------- 3bb139b fix(live): fix testing events
TODO:
->refresh()
method?