Skip to content

Commit

Permalink
bug #1256 Re-adding node 18 support (weaverryan)
Browse files Browse the repository at this point in the history
This PR was merged into the main branch.

Discussion
----------

Re-adding node 18 support

Removing Node 18 support was an accident - #1254 (comment) - so let's fix that :)

Commits
-------

1de3553 Re-adding node 18 support
  • Loading branch information
weaverryan committed Jan 25, 2024
2 parents 64b4e2e + 1de3553 commit c7a6809
Show file tree
Hide file tree
Showing 5 changed files with 93 additions and 104 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/high-depends.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: ['20', '21']
node-versions: ['18', '20', '21']

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/low-depends.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: ['20', '21']
node-versions: ['18', '20', '21']

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stable-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: ['20', '21']
node-versions: ['18', '20', '21']

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"url": "https://github.com/symfony/webpack-encore/issues"
},
"engines": {
"node": ">=20.0.0"
"node": ">=18.0.0"
},
"homepage": "https://github.com/symfony/webpack-encore",
"dependencies": {
Expand Down
Loading

0 comments on commit c7a6809

Please sign in to comment.