Why DefinePlugin is configured only in production?

[dvc]

webpack-encore/lib/plugins/define.js

Line 21 in 929a253

if (!webpackConfig.isProduction()) {

[stof]

hmm, we should probably always defined process.env.NODE_ENV indeed, but making the value development in dev.

[Lyrkan]

That's something I forgot to change when adding a way to configure the plugin.

Before that it was only used for the process.env.NODE_ENV constant so that check wasn't a big issue (even if, as you said @stof, we should probably define it in dev too), but now that there is a way to add new constants (using Encore.configureDefinePlugin()) the plugin has to be added all the time.