Fixing a bug with webpack 3.4.0 with extra arg as an entry #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removal was no longer working The cause was possibly in yargs itself. The new way of calling out to yargs from our library is more proper anyways.
stof
reviewed
Jul 26, 2017
| ); | ||
|
|
||
| const binPath = path.resolve(__dirname, '../', '../', 'bin', 'encore.js'); | ||
| exec(`node ${binPath} dev --context=${testDir}`, { cwd: testDir }, (err, stdout, stderr) => { |
There was a problem hiding this comment.
the 2 paths need to be escaped as they could contain spaces
There was a problem hiding this comment.
Thanks - I just pushed an imperfect escape at sha: 172a670120e79dd6b5f6aaa65845f9892b982ea0 - which is good enough for test paths I think :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
The updated way avoids triggering the "singleton" behavior or yargs. This is important so that later, when webpack uses yargs, it uses the updated
process.argv(because we remove our extra "command" argument so that webpack doesn't see it).I'm not sure exactly which dep/commit caused the issue, but this a more proper solution anyways.
Also added a smoke test for the encore binary.