-
-
Notifications
You must be signed in to change notification settings - Fork 200
Hello Webpack4 ⭐️ #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Hello Webpack4 ⭐️ #324
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
022362f
Upgrading packages to Webpack 4 and replacing extract text by
weaverryan 89499fd
Adding mode option
weaverryan 43b6e30
Removing CommonsChunkPlugin & moving named modules logic
weaverryan 9601780
upgrading all other dependencies & handling babel env changes
weaverryan a1873fc
Fixing deprecated hooks
weaverryan 02dce21
Updating test: mini-css-extract extracts async chunks for css
weaverryan 07add8f
[Minor] Hashes changed in the test
weaverryan f9134b2
[Minor] More test updates for now CSS async are now extracted
weaverryan dfb3611
Moving Uglify configuration
weaverryan 0eac2f0
Removing old test
weaverryan c4c7aec
Updating to new babel react package
weaverryan 172fb62
Completely removing CoffeeScript
weaverryan 8879114
Fixing more @babel/preset-env spots
weaverryan 4ec4fcb
Upgrading to latest vue-loader
weaverryan eb8005f
fixing some version strings in tests
weaverryan 228d3ff
Fixing test - it was a false failure
weaverryan 735bec0
Fixing test related to uglify
weaverryan 7f244c4
Fixing test - internal option location changed
weaverryan 5d940f0
Installing the now-required webpack-cli
weaverryan 3ae0fe0
Updating our custom formatting of vue loader problems
weaverryan d91371a
enhancing createSharedEntry test
weaverryan 9c9becb
Re-adding the traditional createSharedEntry functionality
weaverryan 8c9405c
improving createSharedEntry test
weaverryan 262c206
not using vendor, as it could conflict with built-in cache group
weaverryan 3320418
Adding a warning of you accidentally override a core cache group
weaverryan 51e6088
Hiding the "built at" output
weaverryan d1e9731
Fixing a babelrc change
weaverryan d31eb5d
Adding support for browserslist in package.json!
weaverryan 18fd553
Adding support for configuring splitChunks.chunks to "all"
weaverryan 6cc4624
fixing copy paste
weaverryan a2995b6
enhancing test to also test css splitting
weaverryan 7fda6fd
Adding support for dynamic imports out-of-the-box
weaverryan 51aade6
WIP - changing format of "features" to make room for version
weaverryan 9a9f2b0
Renaming method for future clarity
weaverryan f733bb2
Adding new version-handling logic for optional dependencies
weaverryan 81a079a
upgrading to @babel/plugin-transform-react-jsx
weaverryan 6b17c6f
fixing reversed logic
weaverryan 724a67d
finishing preact babel changes after upgrade
weaverryan 05c5a24
upgrading to @babel/plugin-syntax-dynamic-import
weaverryan 1c41070
Outputting the required version with the "yarn add" recommendations
weaverryan 46a00df
removing failing test
weaverryan 301bd21
Fixing new loading for the .babelrc file
weaverryan 014c304
Fixing very old bug in tests, where the "cwd" passed to parseRuntime()
weaverryan 097592f
updating broken test
weaverryan cbf478f
fixing lint
weaverryan bdf201a
A hacky attempt at supporting createSharedEntry()
weaverryan 049343f
adding a test to prove shared entry code is not double-included
weaverryan de9568d
Omitting the _tmp_shared from the manifest & entrypoints files
weaverryan 2cf72e0
Making shared entry working with versioning
weaverryan ce51d27
fixing typos
weaverryan 2e53737
Clear errors for removed methods
weaverryan f3f8d09
Using semver to enforce our plugin versions a bit better
weaverryan 9558c89
making our entry files plugin last, to catch any entry points that may
weaverryan ce8c0df
Verify that the runtime files are included in entrypoints.json
weaverryan eaebb31
moving test
weaverryan 3b65403
Fixing entrypoints.json so that it points to the unversioned filename
weaverryan 5ba3c11
Adding Encore.splitEntryChunks() to enable that new feature easier
weaverryan 13d7c5b
Fixing bad function name
weaverryan 27f3534
Fixing lint issues
weaverryan 2573899
Fixing windows problems with \ in paths
weaverryan 734c59a
removing support for node 7
weaverryan 1d5786f
Fixing problems with windows slashes in our hacky "require" dumped code
weaverryan 5b19827
*actually* removing Node 7 support
weaverryan fe31d7d
re-adding webpack-dev-server
weaverryan d7cf989
Fixing bad filename in changelog
weaverryan 1acc67a
Changing | to ||, which is the correct format
weaverryan cf0192f
Automatically hashing split filenames on production
weaverryan 55631cc
Fixing a bug where entrypoints.json contained bad names in production
weaverryan 9d2043c
Marking methods as deprecated to help auto-completion
weaverryan f9a0799
Fixing a bug where runtime.js would appear for "style" entries in
weaverryan 75ec093
Always outputting runtime.js
weaverryan 6de05cf
preventing shared entry & split chunks from being used together
weaverryan 20ad1bd
fixing comment
weaverryan 7db0fcb
Adding new Encore.enableSingleRuntimeChunk() + BC layer
weaverryan 75ea6ea
Fixing a bug where logs could break JSON output
weaverryan 4b43766
Adding missing config in test
weaverryan df2a58f
Fixing a bug where async-split chunks caused undefined in
weaverryan 3c1b790
using latest webpack-cli + updating deps
weaverryan ab109cd
Changing entrypoints.json values to include the manifest key prefix
weaverryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
document.getElementById('app').innerHTML = document.getElementById('app').innerHTML + 'Welcome to Encore!'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
// use code splitting via a dynamic import | ||
import('./print_to_app_export').then(printToApp => { | ||
printToApp.default(); | ||
}); |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
document.getElementById('app').innerHTML = 'Welcome to Encore!'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export default function() { | ||
document.getElementById('app').innerHTML = 'Welcome to Encore!'; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
require('./arrow_function'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// used in a createdSharedEntry() test | ||
require('./no_require'); | ||
require('./requires_arrow_function'); | ||
require('./../css/h1_style.css'); | ||
require('./print_to_app'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could also do something in the
EncoreProxy
at the bottom of that file to detect when a user tries to callconfigureExtractTextPlugin
orenableCoffeeScriptLoader
and display some kind of "This method is not available anymore in Webpack Encore" error message instead of the default one?