Skip to content

Improve copyFiles method examples #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2018
Merged

Improve copyFiles method examples #442

merged 1 commit into from
Nov 9, 2018

Conversation

kapiwko
Copy link
Contributor

@kapiwko kapiwko commented Nov 9, 2018

  • add ./assets prefix to path
  • add missing {

@kapiwko
Improve copyFiles method examples
d949d19 
- add ./assets prefix to path
- add missing `{`
@weaverryan
Copy link
Member

Awesome find! Thank you Kamil!

@weaverryan weaverryan merged commit d949d19 into symfony:master Nov 9, 2018
weaverryan added a commit that referenced this pull request Nov 9, 2018
@weaverryan
minor #442 Improve copyFiles method examples (kapiwko)
2b623f7 
This PR was merged into the master branch.

Discussion
----------

Improve `copyFiles` method examples

- add ./assets prefix to path
- add missing `{`

Commits
-------

d949d19 Improve `copyFiles` method examples
@kapiwko kapiwko mentioned this pull request Nov 9, 2018
Merged
weaverryan added a commit that referenced this pull request Nov 10, 2018
@weaverryan
minor #443 Improve copyFiles method examples #2 (kapiwko, weaverryan)
bbf687b 
This PR was merged into the master branch.

Discussion
----------

Improve `copyFiles` method examples #2

Like in #442 Fix also `to` option in examples - paths are relative to build dir, not root dir.

Commits
-------

4b2ceda clarifying comment
676afcb Improve `copyFiles` method examples #2
@kapiwko kapiwko deleted the patch-1 branch November 14, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kapiwko @weaverryan