Fix various issues related to functional tests #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What? The tests are green! Very sensible, and impressive updates. Thank you @Lyrkan! We really needed to get this cleaned up! |
weaverryan
pushed a commit
that referenced
this pull request
Feb 2, 2019
This PR was merged into the master branch. Discussion ---------- Fix various issues related to functional tests This PR fixes various things that currently make the tests result indicators quite unreliable: * Set a `DISABLE_UNSTABLE_CHECKS` environment variable and use it to disable some checks related to filenames with hashes that are subject to frequent changes (for instance `runtime.xxxxxxxx.js` when updating Webpack). This only applies to "Lowest versions of the dependencies" and "Highest versions of the dependencies" jobs. * Fix the Vue.js + Typescript test that was silently failing in the "Lowest versions of the dependencies" job (no idea why it worked for the other ones...) * Increase default timeouts of functional tests from 8s to 10s (since they were frequently failing because of that) * Restore the standard output at the beginning of the compiler callback in `runWebpack()` (doing it later could end up hiding the rest of the job's output if an exception was thrown) Commits ------- b007c0e Fix various issues related to functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various things that currently make the tests result indicators quite unreliable:
Set a
DISABLE_UNSTABLE_CHECKSenvironment variable and use it to disable some checks related to filenames with hashes that are subject to frequent changes (for instanceruntime.xxxxxxxx.jswhen updating Webpack). This only applies to "Lowest versions of the dependencies" and "Highest versions of the dependencies" jobs.Fix the Vue.js + Typescript test that was silently failing in the "Lowest versions of the dependencies" job (no idea why it worked for the other ones...)
Increase default timeouts of functional tests from 8s to 10s (since they were frequently failing because of that)
Restore the standard output at the beginning of the compiler callback in
runWebpack()(doing it later could end up hiding the rest of the job's output if an exception was thrown)