Implement Stimulus bridge configurator #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @tgalopin. |
stof
reviewed
Dec 3, 2020
| 'use strict'; | ||
|
|
||
| const WebpackConfig = require('../WebpackConfig'); //eslint-disable-line no-unused-vars | ||
| const createPlugin = require('@symfony/stimulus-bridge/webpack-helper'); |
There was a problem hiding this comment.
this breaks, because you import this file even when the plugin is not enabled but @symfony/stimulus-bridge is not a dependency of webpack-encore.
And this also misses the dependency checks
There was a problem hiding this comment.
Thanks, I'm having a look!
weaverryan
added a commit
that referenced
this pull request
Dec 3, 2020
This PR was merged into the main branch. Discussion ---------- chore: sync yarn.lock after #859 updates The PR #859 has modified the `package.json` but forgot to update the `yarn.lock`, making all CI builds failing (because we use `yarn --frozen-lockfile`). cc @fabpot @weaverryan 🙏 Commits ------- 093f22d chore: sync yarn.lock after #859 updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Stimulus bridge configurator for Symfony UX