parse empty sequence elements as null

symfony · Sep 16, 2024 · 7025b96 · 7025b96
1 parent 62f96e1
commit 7025b96
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Inline.php b/Inline.php
@@ -355,11 +355,18 @@ private static function parseSequence(string $sequence, int $flags, int &$i = 0,
         ++$i;
 
         // [foo, bar, ...]
+        $lastToken = null;
         while ($i < $len) {
             if (']' === $sequence[$i]) {
                 return $output;
             }
             if (',' === $sequence[$i] || ' ' === $sequence[$i]) {
+                if (',' === $sequence[$i] && (null === $lastToken || 'separator' === $lastToken)) {
+                    $output[] = null;
+                } elseif (',' === $sequence[$i]) {
+                    $lastToken = 'separator';
+                }
+
                 ++$i;
 
                 continue;
@@ -403,6 +410,7 @@ private static function parseSequence(string $sequence, int $flags, int &$i = 0,
 
             $output[] = $value;
 
+            $lastToken = 'value';
             ++$i;
         }
 

diff --git a/Tests/InlineTest.php b/Tests/InlineTest.php
@@ -1004,4 +1004,11 @@ public function testParseQuotedReferenceLikeStringsInSequence()
 
         $this->assertSame(['&foo', '&bar', '&baz'], Inline::parse($yaml));
     }
+
+    public function testParseSequenceWithEmptyElement()
+    {
+        $this->assertSame(['foo', null, 'bar'], Inline::parse('[foo, , bar]'));
+        $this->assertSame([null, 'foo', 'bar'], Inline::parse('[, foo, bar]'));
+        $this->assertSame(['foo', 'bar'], Inline::parse('[foo, bar, ]'));
+    }
 }