Skip to content

Commit

Permalink
[SymForce] return size_t instead of int32_t from values::NumEntries()
Browse files Browse the repository at this point in the history
Topic: chaoqu_symforce_values_num_entries
Reviewers: aaron, brad, nathan, hayk
GitOrigin-RevId: 527716e9b97b3fe89d0db8362686e46304c58b6b
  • Loading branch information
chao-qu-skydio authored and aaron-skydio committed Mar 8, 2023
1 parent 951884c commit 35fd2d9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion symforce/opt/values.cc
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ void Values<Scalar>::UpdateOrSet(const index_t& index, const Values<Scalar>& oth
}

template <typename Scalar>
int32_t Values<Scalar>::NumEntries() const {
size_t Values<Scalar>::NumEntries() const {
return map_.size();
}

Expand Down
2 changes: 1 addition & 1 deletion symforce/opt/values.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class Values {
/**
* Number of keys.
*/
int32_t NumEntries() const;
size_t NumEntries() const;

/**
* Has zero keys.
Expand Down

0 comments on commit 35fd2d9

Please sign in to comment.