[SymForce] Replace empty ctor with =default in factor and values

Topic: chaoqu_symforce_default_ctor GitOrigin-RevId: a4a8b9d942c5efdb54ea7b131d0adcdc1ef90c44
symforce-org · Apr 21, 2023 · 3cc6061 · 3cc6061
1 parent 82d3a1a
commit 3cc6061
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/symforce/opt/factor.h b/symforce/opt/factor.h
@@ -102,7 +102,7 @@ class Factor {
   // Constructors
   // ----------------------------------------------------------------------------------------------
 
-  Factor() {}
+  Factor() = default;
 
   /**
    * Create directly from a (dense/sparse) hessian functor. This is the lowest-level constructor.

diff --git a/symforce/opt/values.cc b/symforce/opt/values.cc
@@ -12,9 +12,6 @@
 
 namespace sym {
 
-template <typename Scalar>
-Values<Scalar>::Values() {}
-
 template <typename Scalar>
 Values<Scalar>::Values(std::initializer_list<Values<Scalar>> others) {
   for (const auto& other : others) {

diff --git a/symforce/opt/values.h b/symforce/opt/values.h
@@ -39,7 +39,7 @@ class Values {
   /**
    * Default construct as empty.
    */
-  Values();
+  Values() = default;
 
   /**
    * Construct from a list of other Values objects. The order of Keys are preserved by