Skip to content

Commit

Permalink
[SymForce] Rename opt/cholesky opt/sparse_cholesky
Browse files Browse the repository at this point in the history
This is because a dense cholesky solver is being added but don't want to
put it in the same directory because of the special license restrictions
of the sparse cholesky solver.

Topic: rename_opt_cholesky
GitOrigin-RevId: b629bfc820bd0d729636cacdb33513a26a8fa685
  • Loading branch information
bradley-solliday-skydio authored and aaron-skydio committed Apr 17, 2023
1 parent caea9da commit f5356d8
Show file tree
Hide file tree
Showing 10 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@
See the License for the specific language governing permissions and
limitations under the License.

# symforce/opt/cholesky
# symforce/opt/sparse_cholesky

Code in symforce/opt/cholesky is adapted from LDL/SuiteSparse and its
Code in symforce/opt/sparse_cholesky is adapted from LDL/SuiteSparse and its
corresponding implementation in the SparseCholesky module of the Eigen library,
and is licensed under the MPL2 license as described in
symforce/opt/cholesky/LICENSE
symforce/opt/sparse_cholesky/LICENSE

# Third Party Code

Expand Down
4 changes: 2 additions & 2 deletions symforce/opt/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ add_metis()
# ------------------------------------------------------------------------------
# symforce_cholesky

file(GLOB SYMFORCE_CHOLESKY_SOURCES CONFIGURE_DEPENDS cholesky/*.cc)
file(GLOB SYMFORCE_CHOLESKY_HEADERS CONFIGURE_DEPENDS cholesky/*.h cholesky/*.tcc)
file(GLOB SYMFORCE_CHOLESKY_SOURCES CONFIGURE_DEPENDS sparse_cholesky/*.cc)
file(GLOB SYMFORCE_CHOLESKY_HEADERS CONFIGURE_DEPENDS sparse_cholesky/*.h sparse_cholesky/*.tcc)
add_library(
symforce_cholesky
${SYMFORCE_LIBRARY_TYPE}
Expand Down
2 changes: 1 addition & 1 deletion symforce/opt/levenberg_marquardt_solver.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
#include <lcmtypes/sym/optimization_stats_t.hpp>
#include <lcmtypes/sym/optimizer_params_t.hpp>

#include "./cholesky/sparse_cholesky_solver.h"
#include "./internal/levenberg_marquardt_state.h"
#include "./linearization.h"
#include "./optimization_stats.h"
#include "./sparse_cholesky/sparse_cholesky_solver.h"
#include "./tic_toc.h"
#include "./values.h"

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion symforce/opt/sparse_schur_solver.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include <Eigen/MetisSupport>
#include <Eigen/Sparse>

#include "./cholesky/sparse_cholesky_solver.h"
#include "./sparse_cholesky/sparse_cholesky_solver.h"

namespace sym {

Expand Down
2 changes: 1 addition & 1 deletion test/sparse_cholesky_solver_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include <catch2/catch_test_macros.hpp>

#include <sym/ops/storage_ops.h>
#include <symforce/opt/cholesky/sparse_cholesky_solver.h>
#include <symforce/opt/sparse_cholesky/sparse_cholesky_solver.h>
#include <symforce/opt/tic_toc.h>

using SparseMatrix = Eigen::SparseMatrix<double>;
Expand Down
2 changes: 1 addition & 1 deletion test/sparse_schur_solver_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include <catch2/catch_test_macros.hpp>
#include <spdlog/spdlog.h>

#include <symforce/opt/cholesky/sparse_cholesky_solver.h>
#include <symforce/opt/sparse_cholesky/sparse_cholesky_solver.h>
#include <symforce/opt/sparse_schur_solver.h>
#include <symforce/opt/tic_toc.h>

Expand Down

0 comments on commit f5356d8

Please sign in to comment.