Use URL for FetchContent #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use URL and URL_HASH for everything, for the reasons described in the comment. Versions of everything are unchanged, except for tl::optional, which is now on an actual release (1.1.0). Tested locally that this works with no dependencies installed on the system, with cmake 3.20 (cmake 3.19 doesn't seem to be available on pypi anymore) Topic: fetchcontent-url-download
|
Reviews in this chain: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use URL and URL_HASH for everything, for the reasons described in the
comment. Versions of everything are unchanged, except for tl::optional,
which is now on an actual release (1.1.0).
Tested locally that this works with no dependencies installed on the
system, with cmake 3.20 (cmake 3.19 doesn't seem to be available on pypi
anymore)
Topic: fetchcontent-url-download