Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

[SYM-3644] Support AWS Provider 5.x #3

Merged

Conversation

llam15
Copy link
Contributor

@llam15 llam15 commented Jun 5, 2023

Summary

  • Supports AWS Provider 5.x by bumping the s3_bucket module version to the most recent (3.1.2)
  • Updates the AWS Provider constraints to >= 4.9.0, to match the constraints required by the s3_bucket module.

Testing

  • Applied the module with the configuration from main
  • Updated the constraints and module, ran terraform init -upgrade && terraform apply. Confirmed that the new configuration applies cleanly with no additional user action.

Screenshot 2023-06-05 at 10 14 13 AM

Screenshot 2023-06-05 at 10 20 25 AM

@linear
Copy link

linear bot commented Jun 5, 2023

SYM-3644 Address Firehose Connector Deprecation Warnings

the firehose kinesis module is complaining

╷
│ Warning: Argument is deprecated
│ 
│   with module.datadog_connector.module.kinesis_firehose_connector.module.s3_bucket.aws_s3_bucket.default,
│   on .terraform/modules/datadog_connector.kinesis_firehose_connector.s3_bucket/main.tf line 14, in resource "aws_s3_bucket" "default":
│   14: resource "aws_s3_bucket" "default" {
│ 
│ Use the aws_s3_bucket_replication_configuration resource instead
│ 
│ (and 19 more similar warnings elsewhere)
╵

The changes required would be breaking, so investigate what upgrading the module would look like and if our other modules need upgrading, and how it will affect customers

@llam15
Copy link
Contributor Author

llam15 commented Jun 5, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@llam15 llam15 requested a review from a team June 5, 2023 14:22
@llam15 llam15 merged commit f87bd3e into main Jun 5, 2023
@llam15 llam15 deleted the leslie/sym-3644-address-firehose-connector-deprecation-warnings branch June 5, 2023 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants