Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DKIM signing not working #1036

Closed
Kenchava opened this issue Nov 18, 2020 · 7 comments · Fixed by #1067
Closed

DKIM signing not working #1036

Kenchava opened this issue Nov 18, 2020 · 7 comments · Fixed by #1067
Labels
bug ready A PR is waiting to be merged. Close to be solved
Milestone

Comments

@Kenchava
Copy link

Version

6.2.24

Installation method

apt (Mail:DKIM is installed)

Expected behavior

DKIM headers of received emails from lists should be populated.

Actual behavior

Message is not signed.

Additional information

/etc/sympa/sympa/sympa.conf:
dkim_feature off
dkim_add_signature_to robot,list
dkim_private_key_path /etc/sympa/sympa/dkim.private
dkim_signature_apply_on md5_authenticated_messages,smime_authenticated_messages,dkim_authenticated_messages,editor_validated_messages
dkim_signer_domain
dkim_selector sympalists

The TXT record containing the public key is deployed at sympalists._domainkey.

The DKIM feature is enabled on my test list as I cannot enable it globally for now.

/var/lib/sympa/list_data//config:
dkim_feature on

@ikedas
Copy link
Member

ikedas commented Nov 19, 2020

Hi @Kenchava ,
Could you please show us these things?

  • the log of Sympa from when you posted a test message to when the message was delivered, and
  • full header of delivered message.

@Kenchava
Copy link
Author

Kenchava commented Nov 19, 2020

Hi @ikedas ,

Late last evening I was actually able to get everything working. DKIM signing began working once it was enabled globally in the sympa.conf file. Originally I had dkim_feature off within sympa.conf and dkim_feature on specified on a specific list.

@ikedas
Copy link
Member

ikedas commented Nov 24, 2020

Hi @Kenchava ,

Hi @ikedas ,

Late last evening I was actually able to get everything working. DKIM signing began working once it was enabled globally in the sympa.conf file. Originally I had dkim_feature off within sympa.conf and dkim_feature on specified on a specific list.

Hmm, that behavior doesn't make sense. I'll submit a pr to fix it in a few days. Thanks for reporting.

@ikedas ikedas reopened this Nov 24, 2020
@ikedas ikedas added the bug label Nov 24, 2020
@ikedas ikedas added this to the 6.2.60 milestone Nov 24, 2020
@racke
Copy link
Contributor

racke commented Nov 29, 2020

Looks like the following Debian bug report is also related to this problem: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954475

@ikedas
Copy link
Member

ikedas commented Nov 30, 2020

@racke, I think that report on Debian looks discussiong on another problem.

@ikedas
Copy link
Member

ikedas commented Dec 1, 2020

Hi @Kenchava and all,

A fix to this bug was included in the recent beta (6.2.59b.2 at 7 Dec). It will be very appreciated to confirm this fix.

@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Dec 1, 2020
ikedas added a commit that referenced this issue Dec 7, 2020
DKIM signing not working if dkim_feature in domain context was not enabled (#1036)
@ikedas
Copy link
Member

ikedas commented Dec 27, 2020

Previous pr #1050 was misleading.

I checked the code from when initially DKIM integration was added, and found that:

  • dkim_feature parameter is available only in domain context (robot.conf or sympa.conf for the default).
  • Configuration schema also defines it in list context (config) where it has been never used.

By a new pr I'll roll back previous change and remove dkim_feature parameter from list context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants