-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: a "delete my account" button #300
Comments
I totally agree with this feature. |
Sounds a good idea to me ... what would be the workflow if the user is logged in to the web interface already? |
Well, ask him/her to enter its password to confirm the action. |
I could use some advices on how to do that properly. See my message on sympa-developpers ML: https://listes.renater.fr/sympa/arc/sympa-developpers/2018-12/msg00003.html Currently, there is only a web interface, asking for the password to confirm identity. I'll test it today. |
Only from web interface for now.
…built-in authentication
This is a very useful feature. However, it is wrong to restrict it to native authentication.
Finally, I think we should restrict unsubscription to the lists where it is allowed, namely base unsubscription on the unsubscribe scenario, which is the standard mechanism for unsubscriptions. If you think it is unfair, then you probably should not allow to close owners unsubscription on your server in the first place (reminder: any scenario - like unsubscribe.closed - can be made unavailable by adding ".hidden" in the end of its name). To sum up, this feature could be generalized by:
OK. That's about it. What do you think? |
@dverdin I think it's good 👍 |
I've wrote why this feature should be enabled only with native (user_table) authentication. See #511 (comment)
I think of the services open to public, such as FramaListes, Slack etc., and focus on the control over personal data: Using those services naturally means leaving user's personal data (typically account information) in trust with these services. It is desirable that the users could control personal data of their own. Conversely, it may not be allowed for the services (itself) dedicated to particular organization including universities, enterprise or other autonomous groups which manage personal data with their own policies by each.
By reason I wrote in above, I agree to add an option to activate/deactivate this feature, while I still think that identity sources not controllable by Sympa should be excluded.
I think this behavior is a fault of design. Using user_table as cache of information about authenticated users might cause leakage of personal data beyond the different identity sources (You can see similar problem on #347). I think information about authenticated users should be kept in volatile web session and should not be stored in any persistent spaces such as user_table without permission by the user themselves (I want to submit PR in near future).
By the reasons above, I disagree to this suggestion.
As I wrote in the comment at the beginning, this matters authorization instead of authentication.
I also don't agree to it. Edit: Insertion. |
Hi Soji!
Ok, so we have the same opinion.
Totally agreed!
I'm sorry, I don't see the reasons above that would lead to disagreement with this.
Indeed. But it is a matter directly related to the current topic. That's why I suggest to use mail instead of password confirmation. In addition, it is also the usual mechanism in Sympa. I don't think we use password confirmation anywhere else. Which makes sense, as we never know which authentication mechanism will be used.
So we agree for everything, except allowing for third party authentication (the email confirmation is a consequence of it). Anyone else having an opinion? |
Well, @dverdin, as you say, email confirmation allows users using external authentication process to delete their account. It sure will be better. The reason I used password is… that I don't know how to create email confirmation 😐 Using email confirmation will, as a bonus, simplify my code. |
If dverdin's idea is adding another authentication with another factor (verifying possession of e-mail mailbox/account along with verifying knowledge of login password), it makes sense. Notes:
@dverdin, if you see I understood correctly, I'll agree to add e-mail confirmation (it may store a request into Sympa::Spool::Auth spool and authenticate it by Sympa::Request::Handler::auth handler). However, I'd like you to understand that the new feature will be available only with users authenticated by user_table by now. And anyway, an option to activate/deactivate this feature looks required. |
Well… you can ask to recover a lost password by mail, so asking for a password is not really a strong protection. I mean, if an attacker has control of the mailbox of a user, he can ask for a new password, use the link in the password-recovery email, then delete the account with the new password. |
Oh, no, I'm not that clever! ;-) However, I understand that it is a very specific query that requires specific security. Email confirmation is, indeed, the same level of security as password because you get or renew your email using the mailbox. So if you get access to the user's mailbox, its password can be considered lost. But as Soji said:
By asking for the password, he only wants the user to realize how important the operation he is doing is. So the crucial part is not "how to check the user's identity." I think that web authentication plus email confirmation is indeed good enough to ensure that the person requesting the action is probably who he says he is. The question would be : how to efficiently warn the user that he is about to delete all his subscriptions and list ownerships? Asking for a password works perfectly for native authentication. But it leaves the other authentication methods orphan, which is sad. I don't have the answer to this problem yet. |
Indeed it's possible. From the beginning, e-mail don't have high secrecy: Transmission channels are often unencrypted; Accounts are occasionally shared among users; .... Since e-mail confirmation is vulnerable, one measure is restricting its effective range, for example: Sending random tokens by each message to be moderated, instead of sending one token to approve all messages; Surely expiring outdated token; Using it in combination with the other authentication method; Not sending token without confirmation by user; and so on. Currently, Sympa overuses e-mail confirmations (for example see #156). However, it doesn't mean that e-mail confirmation is the potent measure for authentication. I suggest to release the next beta including PR #511, possiblly adding an option to activate/deactivate this feature. We would be better to begin with minimum feature. |
Yes. e-mail confirmation must be focused on one precise action and limited in time. Like for one time tickets.
Maybe. Though honestly, we never had any problem with it.
Yes, the problem is deeper than expected. we need a bit of time to think it thoroughly. |
Ok. I'll add an option, marked as "experimental", and disabled by default. I'll do it friday (my day dedicated to Sympa). |
…built-in authentication
Option added! |
Great job @ldidry! |
Very nice, Luc! Thanks! |
Fix #300 — Allow to delete your own account
Thanks for this issue and the implementation! It's been two years, maybe we can finish the "experimental" phase. I propose to enable this by default. Allowing users to delete their personal data is a legal requirement of the GDPR. It it can't be enabled by default, I propose to add this at least to Thanks, and keep up the good work! |
one more year has passed and it's still not straightforward the possibility to delete your account. 😢 |
You can delete your account when |
There should be a "delete my account" button that unsubscribe you from all lists and remove your account immediatly.
To protect that feature, Sympa could
The text was updated successfully, but these errors were encountered: