Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user that he already subscribed to a list #386

Closed
SansPseudoFix opened this issue Jul 25, 2018 · 11 comments
Closed

Notify user that he already subscribed to a list #386

SansPseudoFix opened this issue Jul 25, 2018 · 11 comments
Assignees
Milestone

Comments

@SansPseudoFix
Copy link

Version

6.2.24

Expected behavior

User should be notify that he already has a subscription when he tries to subscribe to a list.

Actual behavior

When a user tries to subscribe to a list he already subscribed, he does not receive a subscription email (seems ok) but he is not informed that he already has a subscription neither.

@ikedas
Copy link
Member

ikedas commented Jul 26, 2018

HI @SansPseudoFix,

I think as following:

If you have not logged in, you have to enter your e-mail address to request for subscribing to the list. Because, Sympa does not know who are you. In fact, everyone can enter your e-mail address instead of their own. Therefore, Sympa would be better not to tell everyone whether you have subscribed or not.

@SansPseudoFix
Copy link
Author

Thank you @ikedas, I see. Seems legit with web interface but maybe, at least, send a mail: "You already are a subscriber of this list"?

@ikedas
Copy link
Member

ikedas commented Jul 26, 2018

@SansPseudoFix, if Sympa sends a mail, I think content of the mail may be such as:

Someone (probably you) requested for subscribing to xxxx list, but you have already subscribed to this list. There is nothing to do on your side.

Is this appropriate? (And is my english sane?)

@SansPseudoFix
Copy link
Author

Yes, I think it's perfect! Thanks again.

(And is my english sane?)

Well, from my french point of view, it seems flawless :P

@ikedas
Copy link
Member

ikedas commented Jul 26, 2018

Thanks for confirming! I'll try to implement it. Please wait for a while (for some weeks).

@ikedas
Copy link
Member

ikedas commented Aug 9, 2018

Hi @SansPseudoFix,
If possible, could you please check this patch by the PR above? (Unfortunately, this may be applicable to recent vrsion, not 6.2.24.)

@ikedas ikedas added this to the 6.2.36 milestone Aug 9, 2018
@ldidry
Copy link
Contributor

ldidry commented Aug 9, 2018

@ikedas I'll update our sympa next tuesday (14/08) and will try your patch. (@SansPseudoFix is one of my coworker)

@ikedas
Copy link
Member

ikedas commented Aug 9, 2018

Thanks! I'll look forward your response.

@ldidry
Copy link
Contributor

ldidry commented Aug 16, 2018

It works! Thank you 🙂

ikedas added a commit that referenced this issue Aug 16, 2018
Notify user that he already subscribed to a list #386
@ikedas
Copy link
Member

ikedas commented Aug 16, 2018

Merged. Thanks for confirming!

@SansPseudoFix, if you feel good, please close this issue.

@SansPseudoFix
Copy link
Author

Yes, perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants