smtpc build warnings

[xavierba]

Hi,

gcc is reporting warnings while building smtpc:

make[2]: Entering directory '/builddir/build/BUILD/sympa-6.2.19b.1/src/smtpc'
CC smtpc.o
CC sockstr.o
smtpc.c: In function 'parse_options':
smtpc.c:229:28: warning: comparison between pointer and zero character constant [-Wpointer-compare]
if (*p == ':' && ++p != '\0')
^~
smtpc.c:229:24: note: did you mean to dereference the pointer?
if (*p == ':' && ++p != '\0')
^~
smtpc.c:272:28: warning: comparison between pointer and zero character constant [-Wpointer-compare]
if (*p == ':' && ++p != '\0')
^~
smtpc.c:272:24: note: did you mean to dereference the pointer?
if (*p == ':' && ++p != '\0')
^~
This is with sympa 6.2.19 beta1 but the warnings were already in 6.2.18.

Also, in 6.2.19 beta 1, smtpc is not installed anymore to libexecdir but to bindir. Is that expected ?

Regards,
Xavier

[ikedas]

@xavierba , I was astonished to see my gcc had been missing these malicious typos. It should be fixed:

• 8c2b5dd...02e4973

Also, in 6.2.19 beta 1, smtpc is not installed anymore to libexecdir but to bindir. Is that expected ?

It is intended: a220ee7 . To keep compatibility to earlier version, --bindir=(libexec directory) have to be added to configure option.

[xavierba]

I can confirm the smtpc build warnings are now gone, thanks.
Also, thanks for the hint about smtpc in bindir rather than libexecdir.

[ikedas]

Merged. Thanks for reviewing & confirming. This issue is closed.