Long request email in message_report

[mathieuroquefort]

In the file message_report.tt2, there are some occurences of the message
[%|loc(list.name,list.host)%]For further information, please contact %1-request@%2[%END%]

But if we have a quite long list name and a quite long list host, the request email ends up being quite long itself (40 chars easily), and the line has more than 76 chars. As the address contains an hyphen, it is cut in the middle of the email, and users cannot click it. Even copying and pasting the email becomes complicated for "normal" users.

A solution would be to introduce a line break before the address.

Version

Sympa 6.1.17 / CentOS 6.10

Installation method

?

Expected behavior

Pour plus de détails, contactez
test-discussion-request@listes.secourspopulaire.fr

Actual behavior

Pour plus de détails, contactez test-discussion-
request@listes.secourspopulaire.fr

Additional information

[ikedas]

Hi @mathieuroquefort,

I guess (but didn't confirm) <test-discussion-request@listes.secourspopulaire.fr> may prevent line folding.

[mathieuroquefort]

You mean adding < and > before and after the email ?
But if I do this in the code, translation won't work anymore.

[ikedas]

Yes, changes on templates will break translations for a while. But at once the changes were included in the codebase, appropriate fixups will be made on translation catalog.

[mathieuroquefort]

So, I shouldn't make any change in my installed version, but wait until it is changed in a new version ?

[ikedas]

To avoid breakage of running site, you can download source of catalog, modify it and install it for your site. We are sorry that we have not updated documentation about translationwork to describe details enough.

[mathieuroquefort]

Actually, I now how to change message_report.tt2. I even can change it only for the robot we use.
But I don't know how to change translation. It is generally more tricky. Not sure I can get into that...

[ikedas]

@mathieuroquefort, could you please apply this patch to check if the problem will be solved?

[mathieuroquefort]

I did not test yet...

[ikedas]

@mathieuroquefort, I was too hasty. Please check the patch on your server.
The patch will be included in the next release planned in this Friday.

[mathieuroquefort]

Hello,

I've looked at it closer.
I don't understand how I can apply this patch. Where is this file suppposed to be located ? There's no /src folder on the server.

[racke]

You can strip off parts of the path inside the patch file with the -p parameter. So if you want just to strip off "src", it would be patch -p1.