Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import.tt2: non-working line break in toolip #562

Closed
1resu opened this issue Mar 5, 2019 · 5 comments · Fixed by #563
Closed

import.tt2: non-working line break in toolip #562

1resu opened this issue Mar 5, 2019 · 5 comments · Fixed by #563
Labels
bug ready A PR is waiting to be merged. Close to be solved
Milestone

Comments

@1resu
Copy link

1resu commented Mar 5, 2019

import.tty defines a line break within a tooltip by the <br/> html tag. This doesn't work.

Using &#013; instead of <br/> should do the trick. Or you can insert a real line break - but this results in changing all language files.

@ikedas
Copy link
Member

ikedas commented Mar 6, 2019

My browsers (Firefox 57, Chrome 72 and IE 11) ignored &#13;. &#13;&#10; looks better. Could you please check this patch?

... - but this results in changing all language files.

No problem. translation catalog will be adjusted at the time of the next release.

@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Mar 6, 2019
@1resu
Copy link
Author

1resu commented Mar 6, 2019

The patch works with my setup (Sympa 6.2.40, Firefox 60.5, Chromium 72) except for the second line break. But this also happens with my initial comment's "solution" (&#013;).

I'm not sure why this happens.

@ikedas
Copy link
Member

ikedas commented Mar 7, 2019

I mislead. The lines looked broken just by word wrapping (CR was ignored and LF was replaced with space by browsers).

Could you please apply this additional patch?

@1resu
Copy link
Author

1resu commented Mar 7, 2019

The patch works like expected. Thanks for your support!

@ikedas
Copy link
Member

ikedas commented Mar 7, 2019

@1resu, thanks for confirming! I'll merge the patches. This issue will be closed.

ikedas added a commit that referenced this issue Mar 7, 2019
import.tt2: non-working line break in toolip (#562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready A PR is waiting to be merged. Close to be solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants