Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing labels for ttl and distribution_ttl #896

Closed
racke opened this issue Feb 27, 2020 · 1 comment · Fixed by #1585
Closed

Confusing labels for ttl and distribution_ttl #896

racke opened this issue Feb 27, 2020 · 1 comment · Fixed by #1585
Labels

Comments

@racke
Copy link
Contributor

racke commented Feb 27, 2020

TTL (time-to-live) values are definitely not timeouts. Given these labels in list config one might easily confuse them with the timeout for the inclusion process.

 'ttl' => {
        order        => 60.12,
        'group'      => 'data_source',
        'gettext_id' => "Inclusions timeout",
        'gettext_comment' =>
            'Sympa caches user data extracted using the include parameter. Their TTL (time-to-live) within Sympa can be controlled using this parameter. The default value is 3600',
        'gettext_unit' => 'seconds',
        'format'       => '\d+',
        'default'      => {'conf' => 'default_ttl'},
        'length'       => 6
    },

    'distribution_ttl' => {
        order        => 60.13,
        'group'      => 'data_source',
        'gettext_id' => "Inclusions timeout for message distribution",
        'gettext_comment' =>
            "This parameter defines the delay since the last synchronization after which the user's list will be updated before performing either of following actions:\n* Reviewing list members\n* Message distribution",
        'gettext_unit' => 'seconds',
        'format'       => '\d+',
        'length'       => 6
    },
@racke racke added the bug label Feb 27, 2020
@ikedas
Copy link
Member

ikedas commented Mar 23, 2020

So what is correct wording?

@ikedas ikedas added the ready A PR is waiting to be merged. Close to be solved label Jan 27, 2023
@ikedas ikedas removed the ready A PR is waiting to be merged. Close to be solved label Jun 2, 2023
ikedas added a commit that referenced this issue Jun 13, 2023
Confusing labels for ttl and distribution_ttl (#896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants