Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› β€” Fix error when rejecting message from direct URL #1687

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Jun 15, 2023

When using the reject URL sent in the moderation notification mail, there is no message_template argument, creating an error. This commit adds a default value for the argument.

The reject URL is like https://example.org/sympa/reject/the_list/token_created_by_sympa.

The error was

DIED: Parameter $tpl is not defined at /var/sympa/share/sympa/lib/Sympa/Message/Template.pm line 64.

And a stacktrace, leading me to the FCGI script.

When using the reject URL sent in the moderation notification mail,
there is no message_template argument, creating an error.
This commit adds a default value for the argument.
@ikedas
Copy link
Member

ikedas commented Jun 24, 2023

I agree to tag this pr as [ready].

@racke racke added the ready A PR is waiting to be merged. Close to be solved label Jun 24, 2023
@racke racke added this to the 6.2.74 milestone Jun 24, 2023
@racke
Copy link
Contributor

racke commented Jun 24, 2023

I agree. Tagged it as ready and added it to the 6.2.74 milestone.

@racke racke merged commit 06d14c0 into sympa-community:main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready A PR is waiting to be merged. Close to be solved security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants