Replace http_host parameter with wwsympa_url_local parameter (addition to #910)
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, the new wwsympa_url_local parameter may be used to specify upstream URL.
|
Thanks for the quick fix @ikedas |
ikedas
added a commit
to ikedas/sympa-community.github.io
that referenced
this pull request
Mar 18, 2020
racke
added a commit
to racke/sympa-ansible
that referenced
this pull request
Mar 18, 2020
racke
added a commit
to racke/sympa-ansible
that referenced
this pull request
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #910.
Though the
http_hostparameter has been obsoleted, many site may set this parameter as the same as host part ofwwsympa_urland they may have to remove it (e.g. see a post on dev list).Instead of keeping this complicating parameter, we'd be better to introduce the new
wwsympa_url_localparameter to specify proxy upstream URL.