Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot include privileged owner from list even if it has to (#969) #973

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Cannot include privileged owner from list even if it has to (#969) #973

merged 1 commit into from
Jul 25, 2020

Conversation

ikedas
Copy link
Member

@ikedas ikedas commented Jul 25, 2020

This may fix #969 .

@ikedas ikedas merged commit 3bea90b into sympa-community:sympa-6.2 Jul 25, 2020
@ikedas ikedas deleted the issue-969 branch July 25, 2020 05:07
@bmarchal54
Copy link
Contributor

Hello
I just tried to upgrade to version 6.2.56. In this version, I had the same problem with not carrying 'privileged' for owners included through a list.
I have the following concern:
Erreurs : Not an ARRAY reference at /usr/share/sympa/lib/Sympa/List.pm line 4752.
Pile d'appel

DIED: Not an ARRAY reference at /usr/share/sympa/lib/Sympa/List.pm line 4752.
at /usr/share/sympa/lib/Sympa/List.pm line 4752.
Sympa::List::_load_include_admin_user_file(Sympa::List dn-test-benoit@tmp.univ-lorraine.fr, HASH(0x776cf68)) called at /usr/share/sympa/lib/Sympa/Request/Handler/include.pm line 99
Sympa::Request::Handler::include::_get_data_sources(Sympa::List dn-test-benoit@tmp.univ-lorraine.fr, 'owner') called at /usr/share/sympa/lib/Sympa/Request/Handler/include.pm line 136
Sympa::Request::Handler::include::_twist(Sympa::Spindle::ProcessRequest=HASH(0x75d0e08), Sympa::Request <action=include;context=dn-test-benoit@tmp.univ-lorraine.fr;role=owner>) called at /usr/share/sympa/lib/Sympa/Spindle.pm line 95
Sympa::Spindle::spin(Sympa::Spindle::ProcessRequest=HASH(0x75d0e08)) called at /usr/share/sympa/lib/Sympa/List.pm line 4789
Sympa::List::sync_include(Sympa::List dn-test-benoit@tmp.univ-lorraine.fr, 'owner') called at /usr/share/sympa/lib/Sympa/List.pm line 407
Sympa::List::new('Sympa::List', 'dn-test-benoit', 'tmp.univ-lorraine.fr', HASH(0x7761af0)) called at /usr/libexec/sympa/wwsympa.fcgi line 10637
main::do_edit_list() called at /usr/libexec/sympa/wwsympa.fcgi line 1556

If you could tell me where my mistake is.

cordially

@racke
Copy link
Contributor

racke commented Sep 1, 2020

Sympa 6.2.56 was released on 24th May, thus it doesn't include this fix.

@bmarchal54
Copy link
Contributor

Yes, I reported this one in the code of the List.pm module.
And that caused the error I gave.

@ikedas
Copy link
Member Author

ikedas commented Sep 2, 2020

@bmarchal54 , could you please show the configuration related to owner_include ?

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 2, 2020 via email

@ikedas
Copy link
Member Author

ikedas commented Sep 2, 2020

So what is the content of inclusion-liste.incl?

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 2, 2020 via email

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 3, 2020 via email

@ikedas
Copy link
Member Author

ikedas commented Sep 4, 2020

Sometines, these are ARRAYs, but there are also HASHs. Wouldn't it come from there?

Can you dump the content of $cfgs ?

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 4, 2020 via email

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 4, 2020 •
edited
Loading

If I add the following line in the code, I no longer have an error:

 foreach my $cfgs (values% include) {
     next if ref $cfgs ne 'ARRAY';
     foreach my $cfg (@ {$cfgs || []}) {

But it may not be complete. In any case, with a quick test, the members of the list pass well as privileged owner.

@ikedas ikedas mentioned this pull request Sep 8, 2020
Closed
@ikedas
Copy link
Member Author

ikedas commented Sep 9, 2020

@bmarchal54 , if possible, can you dump whole value of %include?

$log->syslog('notice', 'patch : valeurs : %s', Dumper(\%include));  # <- Insert this
foreach my $cfgs (values %include) {
...

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 9, 2020 via email

ikedas added a commit to ikedas/sympa that referenced this pull request Sep 9, 2020
@ikedas
Additional fix to sympa-community#973 (sympa-community#969)
d3a2dfe
@ikedas
Copy link
Member Author

ikedas commented Sep 9, 2020

@bmarchal54 ,please apply this additional patch and check if the problem will be solved.

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 9, 2020 via email

@ikedas
Copy link
Member Author

ikedas commented Sep 9, 2020

Please restart wwsympa service (cf. Reloading WWSympa).

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 9, 2020 via email

@ikedas
Copy link
Member Author

ikedas commented Sep 10, 2020

@bmarchal54 , please show the dump of %include.

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 10, 2020 via email

@ikedas
Copy link
Member Author

ikedas commented Sep 10, 2020

And please show the content of *.incl file(s) and all owner_include paragraph(s) in config file.

@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 10, 2020 via email

ikedas added a commit to ikedas/sympa that referenced this pull request Sep 15, 2020
@ikedas
Additional fix to sympa-community#973 (sympa-community#969)
19b8dc1
@ikedas
Copy link
Member Author

ikedas commented Sep 15, 2020

@bmarchal54 , please apply this additional patch for the time being. It will be included in the next release.
Thanks!

ikedas added a commit that referenced this pull request Sep 15, 2020
@ikedas
Merge pull request #997 from ikedas/issue-969 by ikedas
6db8e94 
Additional fix to #973 (#969)
@ikedas ikedas mentioned this pull request Sep 15, 2020
Merged
@bmarchal54
Copy link
Contributor

bmarchal54 commented Sep 15, 2020 via email

ikedas added a commit to ikedas/sympa that referenced this pull request Oct 13, 2020
@ikedas
Additional fix to sympa-community#973 & sympa-community#997 (sympa-co…
971183a 
…mmunity#969)
@ikedas ikedas mentioned this pull request Oct 13, 2020
Merged
ikedas added a commit that referenced this pull request Oct 14, 2020
@ikedas
Merge pull request #1017 from ikedas/issue-969 by ikedas
125765d 
Additional fix to #973 & #997 (#969)
racke pushed a commit to racke/sympa that referenced this pull request Nov 10, 2020
@ikedas @racke
Additional fix to sympa-community#973 & sympa-community#997 (sympa-co…
f2bfaf7 
…mmunity#969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot include privileged owner from list even if it has to
3 participants
@ikedas @bmarchal54 @racke