Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New chapter "Extension Publishing" #12

Closed
twiro opened this issue Mar 3, 2017 · 5 comments
Closed

New chapter "Extension Publishing" #12

twiro opened this issue Mar 3, 2017 · 5 comments

Comments

@twiro
Copy link
Member

twiro commented Mar 3, 2017

I took the introduction of github topics as a reason to finally add a second chapter to this repo - it's about recommendations and best practices regarding "Extension Publishing".

This is only a draft for now and at least the two following points need to be discussed and agreed upon before publishing the chapter to the master-branch.

  1. Should the 1.0.0-syntax be promoted as the official best practice for version-tags of github-releases or should we stick with github's own recommendation of adding a prefixed "v":v1.0.0? I'd vote for the first option as this is how Symphony has used version-tags on github since the repo moved there. And not to forget - the prefixed "v" results in missing links in the compatibility-tables on symphonyextension.com... though I guess & hope this could be fixed.
  2. Should publishing extensions on getsymphony.com still be recommended? I'm not so sure...

Any other feedback or ideas hot to optimize this chapter are welcome!

@nitriques
Copy link
Member

  1. Screw the v. Both composer and npm does not use it. Bye.
  2. No, simply http://symphonyextensions.com/

@twiro
Copy link
Member Author

twiro commented Mar 21, 2017

_ Screw the v. Both composer and npm does not use it. Bye._
_ No, simply http://symphonyextensions.com/_

Fine - thanks for getting this nailed down quickly!

Finished the chapter and will push to master as soon as I have your OK for the current draft in the integration-branch.

@nitriques
Copy link
Member

Use branches

I would also advise about a integration branch, which should receive all pull request and contain stable code.

Nicolas

You might want to consider adding (nitriques) or simply use the username, since I think I might be more recognizable (???)

Everything else LGTM !

@twiro
Copy link
Member Author

twiro commented Mar 22, 2017

I would also advise about a integration branch, which should receive all pull request and contain stable code.

Good advice! I changed the wording in that section to the following:

Use branches to develop and maintain your extension on github. Your basic setup should contain a master-branch (representing the latest stable, tested and documented release) and an integration-branch (that is used for ongoing development and incoming pull requests and should cointain stable code too). Experimental and instable stuff should happen in separate feature-branches.

You might want to consider adding (nitriques) or simply use the username, since I think I might be more recognizable (???)

Changed that too!

Everything else LGTM !

Cool - I released the new chapter in the master-branch and will try to tackle the task "Extension Development" next...

@twiro twiro closed this as completed Mar 22, 2017
@nitriques
Copy link
Member

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants