Fix parameter merge priority to allow user configs to override defaults and invalid disable default workers config #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version 12.3.1, the config loading order was fixed to load default config before user config (commit eef024e). However, the parameter merging logic had the arguments in the wrong order, causing old (default) values to take priority over new (user) values. The ParametersMerger::merge() method gives priority to its first (left) argument. This commit swaps the arguments from merge(oldValue, currentValue) to merge(currentValue, oldValue), ensuring that user configurations properly override default configurations. Fixes the issue where defaultBranch('main') in user config was being overridden by the default 'master' value, breaking custom ReleaseWorkers that depend on the correct branch name. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two configuration issues related to default release workers:
them via compiler pass instead of conditional registration
Changes
Fix #94 #95