Remove NoAbstractMethodRule as way too opinionated (#121)

symplify · May 21, 2024 · a23355d · a23355d
1 parent cb7c2cd
commit a23355d
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 173 deletions.
diff --git a/config/static-rules.neon b/config/static-rules.neon
@@ -11,7 +11,6 @@ rules:
 
     # paths
     - Symplify\PHPStanRules\Rules\NoMissingDirPathRule
-    - Symplify\PHPStanRules\Rules\NoAbstractMethodRule
     - Symplify\PHPStanRules\Rules\NoReferenceRule
     - Symplify\PHPStanRules\Rules\NoArrayAccessOnObjectRule
 

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 43 Rules Overview
+# 42 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -550,38 +550,6 @@ final class SomeService
 
 <br>
 
-## NoAbstractMethodRule
-
-Use explicit interface contract or a service over unclear abstract methods
-
-- class: [`Symplify\PHPStanRules\Rules\NoAbstractMethodRule`](../src/Rules/NoAbstractMethodRule.php)
-
-```php
-abstract class SomeClass
-{
-    abstract public function run();
-}
-```
-
-:x:
-
-<br>
-
-```php
-abstract class SomeClass implements RunnableInterface
-{
-}
-
-interface RunnableInterface
-{
-    public function run();
-}
-```
-
-:+1:
-
-<br>
-
 ## NoArrayAccessOnObjectRule
 
 Use explicit methods over array access on object

diff --git a/src/Rules/NoAbstractMethodRule.php b/src/Rules/NoAbstractMethodRule.php
diff --git a/tests/Rules/NoAbstractMethodRule/Fixture/SkipNonAbstractMethod.php b/tests/Rules/NoAbstractMethodRule/Fixture/SkipNonAbstractMethod.php
diff --git a/tests/Rules/NoAbstractMethodRule/Fixture/SomeAbstractMethod.php b/tests/Rules/NoAbstractMethodRule/Fixture/SomeAbstractMethod.php
diff --git a/tests/Rules/NoAbstractMethodRule/NoAbstractMethodRuleTest.php b/tests/Rules/NoAbstractMethodRule/NoAbstractMethodRuleTest.php
diff --git a/tests/Rules/NoAbstractMethodRule/config/configured_rule.neon b/tests/Rules/NoAbstractMethodRule/config/configured_rule.neon