Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated planet-sympy to Python 3 and Fixed the issue with failing CI #111

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

akshanshbhatt
Copy link
Member

@akshanshbhatt akshanshbhatt commented May 27, 2021

I tried to fix the issue with the TravisCI. These are the significant changes which I made-

  1. Updated the Python version for this project from 2.7 to 3.8. This includes the following changes-

    • Updating the command from python to python3 and from pip to pip3 wherever applicable.
    • Updating the import statements and removing/updating dependencies that are no longer present in python 3.
    • Syntax changes such as print with parentheses, raising exceptions, etc.
    • Modifying the codec of str objects to make them compatible with python 3 standards.

    However,dict type being ordered in python 2, could be sorted like a list. It threw an error at the CI (see the log below). So removing it should not affect the order of feed. I have commented it out for now as I am unsure about the behavior.

    image

  2. Updated the distro image in Dockerconfig from Ubuntu 14.04 to 20.04. I did it because the older version no longer supported some of the apt packages. One of them being python-libxml2.

    python-libxml2 is not listed in the PyPI. It only supported python 2, so we have to look for another reliable XML parser module for RSS. We can translate the libxml2 code to lxml as it is more robust and utilizes libxml2's capabilities. I, for now, have commented out the libxml2 dependent code.

After commenting out the code mentioned in points 1 and 2, CI build passed without any issue. I tested it on my fork, and here is the screenshot -
image
Have a look at the log

@akshanshbhatt
Copy link
Member Author

akshanshbhatt commented May 27, 2021

It failed because of Docker's new rate limit for anonymous and free users. In my fork, I used my docker account credentials to bypass this limit. The limit will reset after some time for this repo.

@asmeurer
Copy link
Member

It still fails. I think we need to switch to a different Docker hosting service.

@akshanshbhatt
Copy link
Member Author

It still fails. I think we need to switch to a different Docker hosting service.

I agree. Docker has changed its Terms of service lately. Without the login credentials, it won't be possible to prevent the CI from failing.

@asmeurer
Copy link
Member

@certik the planet system is completely broken. The GitLab CI is working, but it isn't getting the latest changes (I merged a PR with a new blog and it isn't getting picked up). The Travis CI on GitHub does not work, because it no longer has Python 2, and it cannot access DockerHub due to changes in their terms of service. Do you have any thoughts on how we can fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants