Updated planet-sympy to Python 3 and Fixed the issue with failing CI #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix the issue with the TravisCI. These are the significant changes which I made-
Updated the Python version for this project from 2.7 to 3.8. This includes the following changes-
python
topython3
and frompip
topip3
wherever applicable.print
with parentheses, raising exceptions, etc.str
objects to make them compatible with python 3 standards.However,
dict
type being ordered in python 2, could be sorted like a list. It threw an error at the CI (see the log below). So removing it should not affect the order of feed. I have commented it out for now as I am unsure about the behavior.Updated the distro image in Dockerconfig from Ubuntu 14.04 to 20.04. I did it because the older version no longer supported some of the apt packages. One of them being python-libxml2.
python-libxml2 is not listed in the PyPI. It only supported python 2, so we have to look for another reliable XML parser module for RSS. We can translate the libxml2 code to lxml as it is more robust and utilizes libxml2's capabilities. I, for now, have commented out the libxml2 dependent code.
After commenting out the code mentioned in points 1 and 2, CI build passed without any issue. I tested it on my fork, and here is the screenshot -
Have a look at the log