Fix Sphinx extension #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sphinx now seems to use the 'highlight-default' class for all code blocks, including Python ones, so we were not processing any of them. This commit changes the extension to scan all code blocks to avoid this.
Sphinx adds a blank span tag to the beginning of each code block now, which broke the feature that let you click on a line to execute it. Now the extension considers the content of the first two elements in each line of code when deciding whether a line is a Python statement or output, avoiding this problem.
|
None of the javascript is loading on the demo page because it's not being served over https. |
|
Hmm, it should work without HTTPS. However, the certificate for the appspot.com domain doesn't support sub-subdomains, so we can't test it. I did just redeploy with HTTPS enabled, but no dice - the certificate validation fails. |
|
Well docs.sympy.org its itself not https, so this won't be an issue when we deploy there. So I'm +1 to just merge this if it works. |
|
Well, pushing with |
|
Alright, the demo should work again. |
|
I forgot that you can manually load unsafe scripts in Chrome. This seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
highlight-pythonclass which Sphinx no longer addsDemo: http://lidavidm.github.io/sympy (may need to force-refresh, Control-Shift-R)