-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved all the relevant solver-related test cases to test_solvers.py #18704
Conversation
✅ Hi, I am the SymPy bot (v157). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
|
🟠Hi, I am the SymPy bot (v157). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it. This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75. The following commits add new files:
If these files were added/deleted on purpose, you can ignore this message. |
# [ 1/(x + 1)]]) | ||
|
||
@XFAIL # dotprodsimp is not on by default in this function | ||
def test_issue_17247_expression_blowup_32(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can ignore the tests like expression_blowup
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the suggestion.
there are conflicts have you updated ( |
I the past there have been issues with having two files with the same name in the repo. I don't know if those issues still exist, but it's worth checking if there are any problems, since we already have sympy/solvers/tests/test_solvers.py . |
Thank you, @mohitacecode for mentioning, I hadn't pulled the changes before. Now I have pulled the changes from my fork to my local repository. Do I have to pull the changes from the sympy/sympy repository too? Can I update the pull request somehow or do I have to open a new pull request after fetching the changes? I am new to open source and it would be great if someone could help me out. |
@asmeurer , thank you for pointing this out. I would check this and then possibly rename the file. |
There is already |
Try to pull the changes from |
Thank you for your help and sorry for the delay as I was unable to give much time to this because of having exams now. |
Unfortunately, #18793 had arrived to the solution faster, so I may close this. |
References to other Issues or PRs:
Partial fix for #18666
Brief description of what is fixed or changed
moved all the solver - related test cases from the existing files test_matrices.py and test_commonmatrix.py to a new file test_solvers.py.
Other comments
Release Notes