Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Elliptic curve #2449

Closed
wants to merge 23 commits into from
Closed

WIP: Elliptic curve #2449

wants to merge 23 commits into from

Conversation

shikil
Copy link
Contributor

@shikil shikil commented Sep 11, 2013

  • Add docstring
  • Add test case
  • Calculate torsion points

@asmeurer
Copy link
Member

Doesn't characteristic 2 have to be treated separately?

@shikil
Copy link
Contributor Author

shikil commented Sep 12, 2013

I am studying, the book does not specifically mention characteristic 2 yet, if you have paper/code regarding this, please post here.

@shikil
Copy link
Contributor Author

shikil commented Sep 12, 2013

@asmeurer, I guess that you mean this

http://www.certicom.com/index.php/40-elliptic-curve-groups-over-f2m

This kind of prime power field, Galois field, may be implemented in other pull request.

@asmeurer
Copy link
Member

Even over the two element field it is different. If I remember correctly, the nonsingular condition changes in that case.

@shikil
Copy link
Contributor Author

shikil commented Sep 12, 2013

EC y^2 = x^3 + ax +b must be singular in char 2 or 3. So the curve need to be y^2 + a1y + a3xy = x^3 + a2x^2 + a4x + a6 in this form.

@jrioux
Copy link
Member

jrioux commented Nov 13, 2013

SymPy Bot Summary: 🔴 Failed after merging shikil/ec (6ae5c68) into master (dad12ba).
@shikil: Please fix the test failures.
🔴 PyPy 2.0.0-beta-1; 2.7.3-final-42: fail
🔴 Python 2.7.2-final-0: fail
🔴 Python 3.2.1-final-0: fail
Sphinx 1.1.3: pass
Doc Coverage: decreased
36.711% of functions have doctests (compared to 36.678% in master)
41.853% of functions are imported into Sphinx (compared to 41.930% in master)

@hargup
Copy link
Contributor

hargup commented May 20, 2014

@shikil any news?

@shikil
Copy link
Contributor Author

shikil commented May 21, 2014

Sorry, I am busy and cannot continue work on this.

@jksuom
Copy link
Member

jksuom commented Dec 11, 2019

This is almost complete. It should probably be placed in polys/agca instead of ntheory.

@abhinav-anand-addepar
Copy link
Member

I am taking this over.

This was referenced Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants