Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing Output Assignment to Flink in Flink-NATS Connector #15

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

souravagrawal
Copy link
Contributor

@souravagrawal souravagrawal commented Dec 14, 2024

  • Fix Nats Consumer Output Assignment Issue in Flink Integration, it fixes [https://github.com/JetStream source not working as expected. #14].
    Statement was missing which would provide the nats Consumer message to flink for further processing
  • Fix Nats Connection Closed Error During Message Acknowledgment.
    Existing implementation was throwing error while acknowledgding a message, to solve this we are publishing a message to ReplyTo subject and "+ACK" string. Open for suggestion if we can fix it differently
  • Implement Stop/Continue Logic for Flink Job Based on Boundedness and Batch Message Count .
    Added boundess configuration in NatsJetstreamSourceBuilder based on which a job will either infinitely run (CONTIONUOUSLY_BOUNDESS) or stop (BOUNDED) when received message count are <= configured max_fetch record. We can enhance this change further based on requirement.

I will improve the test cases going forward.

Copy link
Collaborator

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf
Copy link
Collaborator

scottf commented Dec 17, 2024

@souravagrawal Please sign commits from now on.

@scottf scottf merged commit 22431dc into synadia-io:main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants