--if-present flag to run spellcheck only if in package.json script

synapsecns · Oct 29, 2024 · f3566a4 · f3566a4
1 parent 55bedbb
commit f3566a4
Show file tree

Hide file tree

Showing 15 changed files with 10 additions and 16 deletions.
diff --git a/.github/workflows/packages.yml b/.github/workflows/packages.yml
@@ -42,7 +42,7 @@ jobs:
         run: npx lerna exec npm run ci:lint --parallel
 
       - name: Run spellcheck # Run spellcheck of all packages
-        run: npx lerna exec npm run ci:spellcheck --parallel
+        run: npx lerna exec npm run ci:spellcheck --parallel -- --if-present
 
   test:
     runs-on: ubuntu-latest

diff --git a/docs/bridge/package.json b/docs/bridge/package.json
@@ -15,7 +15,8 @@
     "test:coverage": " ",
     "build:go": " ",
     "build:slither": " ",
-    "ci:spellcheck": "cspell \"**/*.{md,mdx}\" --show-suggestions",
+    "spellcheck": "cspell \"**/*.{md,mdx}\" --show-suggestions",
+    "ci:spellcheck": "cspell \"**/*.{md,mdx}\" --no-progress --show-suggestions",
     "write-heading-ids": "docusaurus write-heading-ids",
     "typecheck": "tsc"
   },

diff --git a/packages/contracts-core/package.json b/packages/contracts-core/package.json
@@ -14,8 +14,7 @@
     "lint:contracts:fix": "forge fmt && solhint --fix -c .solhint.json '{contracts,script,test}/**/*.sol'",
     "lint:fix": "yarn lint:contracts:fix",
     "lint": "forge fmt",
-    "ci:lint": "forge fmt --check && solhint -c .solhint.json '{contracts,script,test}/**/*.sol'",
-    "ci:spellcheck": " "
+    "ci:lint": "forge fmt --check && solhint -c .solhint.json '{contracts,script,test}/**/*.sol'"
   },
   "files": [
     "contracts/**/*.sol",

diff --git a/packages/contracts-rfq/package.json b/packages/contracts-rfq/package.json
@@ -26,7 +26,6 @@
     "lint": "forge fmt && npm run solhint",
     "lint:check": "forge fmt --check && npm run solhint:check",
     "ci:lint": "npm run lint:check",
-    "ci:spellcheck": " ",
     "build:go": "./flatten.sh contracts/*.sol test/*.sol",
     "solhint": "solhint '{contracts,script,test}/**/*.sol' --fix --noPrompt --max-warnings 3",
     "solhint:check": "solhint '{contracts,script,test}/**/*.sol' --max-warnings 3"

diff --git a/packages/coverage-aggregator/package.json b/packages/coverage-aggregator/package.json
@@ -21,7 +21,6 @@
     "lint": "npm run lint:fix && npm run lint:check",
     "lint:check": "eslint . --max-warnings=0 --ext ts --ext tsx --ext js --ext jsx",
     "ci:lint": "npm run lint:check",
-    "ci:spellcheck": " ",
     "build:go": " ",
     "build": " ",
     "build:slither": " ",

diff --git a/packages/explorer-ui/package.json b/packages/explorer-ui/package.json
@@ -56,7 +56,8 @@
     "storybook": "start-storybook -p 6006",
     "build-storybook": "build-storybook",
     "lint:fix": "npm run lint -- --fix",
-    "ci:spellcheck": "cspell \"**/*.{tsx,jsx,md,mdx}\" --show-suggestions",
+    "spellcheck": "cspell \"**/*.{tsx,jsx,md,mdx}\" --show-suggestions",
+    "ci:spellcheck": "cspell \"**/*.{tsx,jsx,md,mdx}\" --no-progress --show-suggestions",
     "lint:check": "eslint . --max-warnings=0"
   },
   "browserslist": {

diff --git a/packages/rest-api/package.json b/packages/rest-api/package.json
@@ -14,7 +14,6 @@
     "lint:fix": "eslint src/**/*.ts --fix",
     "lint:check": "eslint . --max-warnings=0",
     "ci:lint": "npm run lint:check",
-    "ci:spellcheck": " ",
     "test": "jest",
     "test:coverage": "jest --collect-coverage"
   },

diff --git a/packages/rfq-indexer/api/package.json b/packages/rfq-indexer/api/package.json
@@ -13,7 +13,6 @@
     "dev": "dotenv -e .env -- tsx watch src/app.ts",
     "lint:check": " ",
     "ci:lint": " ",
-    "ci:spellcheck": " ",
     "build:go": " ",
     "build": " ",
     "build:slither": " ",

diff --git a/packages/rfq-indexer/indexer/package.json b/packages/rfq-indexer/indexer/package.json
@@ -11,7 +11,6 @@
     "codegen": "ponder codegen",
     "lint": "eslint .",
     "ci:lint": "eslint .",
-    "ci:spellcheck": " ",
     "typecheck": "tsc",
     "test:coverage": "echo 'No tests defined.'",
     "build:go": " ",

diff --git a/packages/rfq-loadtest/package.json b/packages/rfq-loadtest/package.json
@@ -8,7 +8,6 @@
     "build": "cp src/pyRepeater.py dist/ && tsc",
     "lint": "eslint .",
     "ci:lint": "eslint .",
-    "ci:spellcheck": " ",
     "typecheck": "tsc",
     "test:coverage": "echo 'No tests defined.'",
     "build:go": " ",

diff --git a/packages/sdk-router/package.json b/packages/sdk-router/package.json
@@ -28,7 +28,8 @@
     "prepare": "tsdx build",
     "preinstall": "command -v tsdx >/dev/null 2>&1 && tsdx build || echo 'tsdx not found'",
     "size": "size-limit",
-    "ci:spellcheck": "cspell \"README.md\" --show-suggestions",
+    "spellcheck": "cspell \"README.md\" --show-suggestions",
+    "ci:spellcheck": "cspell \"README.md\" --no-progress --show-suggestions",
     "analyze": "size-limit --why",
     "build:go": " ",
     "build:slither": " "

diff --git a/packages/solidity-devops/package.json b/packages/solidity-devops/package.json
@@ -23,7 +23,6 @@
     "build:go": " ",
     "build:slither": " ",
     "ci:lint": "npm run lint:check",
-    "ci:spellcheck": " ",
     "lint": "forge fmt && eslint . --fix --ext js && solhint --fix -c .solhint.json '{src,script,test}/**/*.sol'",
     "lint:check": "forge fmt --check && eslint . --max-warnings=0 --ext js && solhint -c .solhint.json '{src,script,test}/**/*.sol'",
     "test:coverage": "echo 'TODO: Add test coverage'"

diff --git a/packages/synapse-constants/package.json b/packages/synapse-constants/package.json
@@ -20,7 +20,6 @@
   "scripts": {
     "test:coverage": "echo 'No tests defined.'",
     "ci:lint": " ",
-    "ci:spellcheck": " ",
     "build:go": " ",
     "build:slither": " ",
     "lint": " ",

diff --git a/packages/synapse-interface/package.json b/packages/synapse-interface/package.json
@@ -22,7 +22,8 @@
     "build:slither": " ",
     "graphql:generate": "graphql-codegen --config codegen.ts",
     "maps:generate": "node scripts/generateMaps.js",
-    "ci:spellcheck": "cspell \"**/*.{tsx,jsx,md,mdx}\" --show-suggestions",
+    "spellcheck": "cspell \"**/*.{tsx,jsx,md,mdx}\" --show-suggestions",
+    "ci:spellcheck": "cspell \"**/*.{tsx,jsx,md,mdx}\" --no-progress --show-suggestions",
     "test": "echo 'No jest tests defined.'"
   },
   "dependencies": {

diff --git a/packages/widget/package.json b/packages/widget/package.json
@@ -24,7 +24,6 @@
     "test:coverage": "echo 'No tests defined.'",
     "lint:check": "eslint . --max-warnings=0",
     "ci:lint": "npm run lint:check",
-    "ci:spellcheck": " ",
     "build:go": " ",
     "build:slither": " ",
     "prepare": "rollup -c --bundleConfigAsCjs"