Fraud reporting

.editorconfig

@@ -15,6 +15,7 @@ indent_size = 4
 [*.go]
 indent_size = 4
 indent_style = tab
+import_style = go
 
 [*.yml]
 quote_type = single

.github/workflows/go.yml

@@ -25,7 +25,7 @@ jobs:
     outputs:
       # Expose matched filters as job 'packages' output variable
       packages_deps: ${{ steps.filter_go_deps.outputs.changed_modules }}
-      packages_nodeps:  ${{ steps.filter_go_nodeps.outputs.changed_modules }}
+      packages_nodeps: ${{ steps.filter_go_nodeps.outputs.changed_modules }}
       package_count_deps: ${{ steps.length.outputs.FILTER_LENGTH_DEPS }}
       package_count_nodeps: ${{ steps.length.outputs.FILTER_LENGTH_NODEPS }}
       solidity_changes: ${{ steps.filter_solidity.outputs.any_changed }}
@@ -160,12 +160,34 @@ jobs:
           PYROSCOPE_PATH: '${{ steps.pyroscope-path.outputs.PYROSCOPE_PATH }}'
           APPLICATION_NAME: ${{ steps.coverage.outputs.flag }}
 
+      - name: Precompile Tests
+        working-directory: ${{ matrix.package }}
+        run: go test -run=nope ./...
+        env:
+          # no other containers are running at this point so we can use all available memory for compilation
+          GOMEMLIMIT: 5GiB
+          GOGC: -1
+
       - name: Test
         uses: nick-fields/retry@v2
         with:
-          command: cd ${{matrix.package}} && $PYROSCOPE_PATH exec --apiKey=${{ secrets.PYROSCOPE_CLOUD_TOKEN }} -- go test -parallel 1 -coverpkg=./... ./... -coverprofile=profile.cov
-          max_attempts: 2
-          timeout_minutes: 20
+          command: |
+            set -e
+            cd ${{ matrix.package }}
+            echo "mode: atomic" > coverage.txt
+            for pkg in $(go list ./...); do
+              #$PYROSCOPE_PATH exec --apiKey=${{ secrets.PYROSCOPE_CLOUD_TOKEN }} -- go test -coverpkg="$pkg" -coverprofile=profile.cov $pkg
+              go test -coverpkg="$pkg" -coverprofile=profile.cov $pkg
+              if [ -f profile.cov ]; then
+                tail -n +2 profile.cov >> coverage.txt
+                rm profile.cov
+              fi
+            done
+            cp coverage.txt profile.cov
+            docker ps
+          on_retry_command: docker rm -f $(docker ps -a -q)
+          max_attempts: 5
+          timeout_minutes: 60
         env:
           PYROSCOPE_PATH: '${{ steps.pyroscope-path.outputs.PYROSCOPE_PATH }}'
           ENABLE_MYSQL_TEST: true
@@ -180,6 +202,29 @@ jobs:
           ETHEREUM_RPC_URI: ${{ secrets.ETHEREUM_RPC_URI }}
           GOPROXY: https://proxy.golang.org
 
+      # TODO: these 3 steps should be moved into a reusable action.
+      # also,should be noted these aren't comprehensive, as many of the containers are automatically removed
+      # and we'd need something like this for all logs: https://github.com/synapsecns/sanguine/pull/1280#discussion_r1320889916
+      # but this should be better than nothing as long as you don't assume the logs are complete
+      #
+      # there's a good case to have this in addition to the suggestions referenced in the comment above because
+      # logs are not collected there in the case of sigterms (because logs stop piping when app breaks), which are caught here
+      #
+      # in any case this should be considered an early implementation
+      - name: Collect docker logs
+        if: always()
+        uses: jwalton/gh-docker-logs@v2
+        with:
+          dest: '/tmp/logs'
+      - name: Tar logs
+        if: failure()
+        run: tar cvzf ./logs.tgz /tmp/logs
+      - name: Upload logs to GitHub
+        if: failure()
+        uses: actions/upload-artifact@master
+        with:
+          name: ${{matrix.package}}-logs.tgz
+          path: ./logs.tgz
 
       - name: Send Coverage (Codecov)
         uses: Wandalen/wretry.action@v1.0.36
@@ -278,7 +323,6 @@ jobs:
           GOMEMLIMIT: 6GiB
           GOGC: -1
 
-
   issue_number:
     # this is needed to prevent us from hitting the github api rate limit
     name: Get The Issue Number
@@ -293,7 +337,6 @@ jobs:
       - uses: jwalton/gh-find-current-pr@v1
         id: find_pr
 
-
   # check if we need to rerun go generate as a result of solidity changes. Note, this will only run on solidity changes.
   # TODO: consolidate w/ go change check. This will run twice on agents
   check-generation-solidity:
@@ -431,7 +474,6 @@ jobs:
         run: yarn install --immutable
         if: ${{ contains(matrix.package, 'agents') }}
 
-
       # Generate flattened files
       - name: Run flattener
         run: npx lerna exec npm run build:go
@@ -458,7 +500,6 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-go-generate-${{matrix.package}}
 
-
       - name: Cache Linuxbrew
         uses: actions/cache@v3
         if: ${{ contains(matrix.package, 'scribe') }}
@@ -485,18 +526,17 @@ jobs:
 
       - name: Run Make Generate CI Deps (Scribe)
         working-directory: ${{matrix.package}}/
-        if:  ${{ contains(matrix.package, 'scribe') }}
+        if: ${{ contains(matrix.package, 'scribe') }}
         run: |
           export PATH=$PATH:$(go env GOPATH)/bin
           make generate-ci || exit 0
 
       - name: Run Make Generate CI (Scribe)
         working-directory: ${{matrix.package}}/
-        if:  ${{ contains(matrix.package, 'scribe') }}
+        if: ${{ contains(matrix.package, 'scribe') }}
         run: |
           make generate-ci
 
-
       # See if we need to rerun go generate
       # TODO: consider implementing https://github.com/golang/go/issues/20520 to speed up process if possible
       - name: Try Go Generate

agents/agents/agentsintegration/agentsintegration_test.go

@@ -6,7 +6,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/Flaque/filet"
 	awsTime "github.com/aws/smithy-go/time"
 	"github.com/brianvoe/gofakeit/v6"
 	"github.com/ethereum/go-ethereum/accounts/abi/bind"
@@ -25,6 +24,8 @@ import (
 	"github.com/synapsecns/sanguine/services/scribe/client"
 	scribeConfig "github.com/synapsecns/sanguine/services/scribe/config"
 	"github.com/synapsecns/sanguine/services/scribe/service"
+
+	"github.com/Flaque/filet"
 )
 
 func RemoveAgentsTempFile(t *testing.T, fileName string) {
@@ -211,7 +212,7 @@ func (u *AgentsIntegrationSuite) TestAgentsE2E() {
 
 	Equal(u.T(), encodedNotaryTestConfig, decodedAgentConfigBackToEncodedBytes)
 
-	guard, err := guard.NewGuard(u.GetTestContext(), guardTestConfig, omniRPCClient, u.GuardTestDB, u.GuardMetrics)
+	guard, err := guard.NewGuard(u.GetTestContext(), guardTestConfig, omniRPCClient, scribeClient.ScribeClient, u.GuardTestDB, u.GuardMetrics)
 	Nil(u.T(), err)
 
 	tips := types.NewTips(big.NewInt(0), big.NewInt(0), big.NewInt(0), big.NewInt(0))
@@ -251,7 +252,9 @@ func (u *AgentsIntegrationSuite) TestAgentsE2E() {
 	go func() {
 		// we don't check errors here since this will error on cancellation at the end of the test
 		err = guard.Start(u.GetTestContext())
-		u.Nil(err)
+		if !testDone {
+			u.Nil(err)
+		}
 	}()
 
 	u.Eventually(func() bool {

agents/agents/exampleagent/exampleagent_test.go

@@ -12,15 +12,15 @@ func (u ExampleAgentSuite) TestExampleAgentSimulatedTestSuite() {
 	Nil(u.T(), err)
 	Equal(u.T(), uint32(u.TestBackendDestination.GetChainID()), notaryStatus.Domain)
 
-	notaryStatusFromEVM, err := u.SummitDomainClient.BondingManager().GetAgentStatus(u.GetTestContext(), u.NotaryBondedSigner)
+	notaryStatusFromEVM, err := u.SummitDomainClient.BondingManager().GetAgentStatus(u.GetTestContext(), u.NotaryBondedSigner.Address())
 	Nil(u.T(), err)
 	Equal(u.T(), notaryStatusFromEVM.Domain(), uint32(u.TestBackendDestination.GetChainID()))
 
 	guardStatus, err := u.SummitContract.AgentStatus(&bind.CallOpts{Context: u.GetTestContext()}, u.GuardBondedSigner.Address())
 	Nil(u.T(), err)
 	Equal(u.T(), uint32(0), guardStatus.Domain)
 
-	guardStatusFromEVM, err := u.SummitDomainClient.BondingManager().GetAgentStatus(u.GetTestContext(), u.GuardBondedSigner)
+	guardStatusFromEVM, err := u.SummitDomainClient.BondingManager().GetAgentStatus(u.GetTestContext(), u.GuardBondedSigner.Address())
 	Nil(u.T(), err)
 	Equal(u.T(), guardStatusFromEVM.Domain(), uint32(0))
 }

agents/agents/executor/cmd/commands.go

@@ -119,8 +119,8 @@ var ExecutorRunCommand = &cli.Command{
 		case "embedded":
 			eventDB, err := scribeAPI.InitDB(
 				ctx,
-				executorConfig.ScribeConfig.EmbeddedDBConfig.Type,
-				executorConfig.ScribeConfig.EmbeddedDBConfig.Source,
+				executorConfig.DBConfig.Type,
+				executorConfig.DBConfig.Source,
 				handler,
 				false,
 			)
@@ -157,7 +157,7 @@ var ExecutorRunCommand = &cli.Command{
 
 			embedded := client.NewEmbeddedScribe(
 				executorConfig.ScribeConfig.EmbeddedDBConfig.Type,
-				executorConfig.ScribeConfig.EmbeddedDBConfig.Source,
+				executorConfig.DBConfig.Source,
 				handler,
 			)
 

agents/agents/executor/db/suite_test.go

@@ -3,23 +3,25 @@ package db_test
 import (
 	"database/sql"
 	"fmt"
+	"os"
+	"sync"
+	"sync/atomic"
+	"testing"
+	"time"
+
 	"github.com/Flaque/filet"
 	. "github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/suite"
 	"github.com/synapsecns/sanguine/agents/agents/executor/db"
 	"github.com/synapsecns/sanguine/agents/agents/executor/db/sql/mysql"
 	"github.com/synapsecns/sanguine/agents/agents/executor/db/sql/sqlite"
 	"github.com/synapsecns/sanguine/agents/agents/executor/metadata"
+	"github.com/synapsecns/sanguine/core"
 	"github.com/synapsecns/sanguine/core/dbcommon"
 	"github.com/synapsecns/sanguine/core/metrics"
 	"github.com/synapsecns/sanguine/core/metrics/localmetrics"
 	"github.com/synapsecns/sanguine/core/testsuite"
 	"gorm.io/gorm/schema"
-	"os"
-	"sync"
-	"sync/atomic"
-	"testing"
-	"time"
 )
 
 type DBSuite struct {
@@ -41,10 +43,18 @@ func NewEventDBSuite(tb testing.TB) *DBSuite {
 func (t *DBSuite) SetupSuite() {
 	t.TestSuite.SetupSuite()
 
-	localmetrics.SetupTestJaeger(t.GetSuiteContext(), t.T())
+	// don't use metrics on ci for integration tests
+	isCI := core.GetEnvBool("CI", false)
+	useMetrics := !isCI
+	metricsHandler := metrics.Null
+
+	if useMetrics {
+		localmetrics.SetupTestJaeger(t.GetSuiteContext(), t.T())
+		metricsHandler = metrics.Jaeger
+	}
 
 	var err error
-	t.metrics, err = metrics.NewByType(t.GetSuiteContext(), metadata.BuildInfo(), metrics.Jaeger)
+	t.metrics, err = metrics.NewByType(t.GetSuiteContext(), metadata.BuildInfo(), metricsHandler)
 	Nil(t.T(), err)
 }
 

agents/agents/executor/executor.go

@@ -65,6 +65,8 @@
 	rpcClient Backend
 	// boundDestination is a bound destination contract.
 	boundDestination domains.DestinationContract
+	// boundOrigin is a bound origin contract.
+	boundOrigin domains.OriginContract
 }
 
 // Executor is the executor agent.
@@ -73,8 +75,6 @@
 	config executor.Config
 	// executorDB is the executor agent database.
 	executorDB db.ExecutorDB
-	// scribeClient is the client to the Scribe gRPC server.
-	scribeClient client.ScribeClient
 	// grpcClient is the gRPC client.
 	grpcClient pbscribe.ScribeServiceClient
 	// grpcConn is the gRPC connection.
@@ -87,6 +87,8 @@
 	handler metrics.Handler
 	// txSubmitter is the transaction submitter.
 	txSubmitter submitter.TransactionSubmitter
+	// NowFunc returns the current time.
+	NowFunc func() time.Time
 }
 
 // logOrderInfo is a struct to keep track of the order of a log.
@@ -198,6 +200,11 @@
 			return nil, fmt.Errorf("could not bind destination contract: %w", err)
 		}
 
+		boundOrigin, err := evm.NewOriginContract(ctx, chainClient, common.HexToAddress(chain.OriginAddress))
+		if err != nil {
+			return nil, fmt.Errorf("could not bind origin contract: %w", err)
+		}
+
 		tree, err := newTreeFromDB(ctx, chain.ChainID, executorDB)
 		if err != nil {
 			return nil, fmt.Errorf("could not get tree from db: %w", err)
@@ -219,19 +226,20 @@
 			merkleTree:       tree,
 			rpcClient:        evmClient,
 			boundDestination: boundDestination,
+			boundOrigin:      boundOrigin,
 		}
 	}
 
 	return &Executor{
 		config:         config,
 		executorDB:     executorDB,
-		scribeClient:   scribeClient,
 		grpcConn:       conn,
 		grpcClient:     grpcClient,
 		signer:         executorSigner,
 		chainExecutors: chainExecutors,
 		handler:        handler,
 		txSubmitter:    txSubmitter,
+		NowFunc:        time.Now,
 	}, nil
 }
 
@@ -784,7 +792,7 @@
 			backoffInterval = time.Duration(e.config.ExecuteInterval) * time.Second
 
 			page := 1
-			currentTime := uint64(time.Now().Unix())
+			currentTime := uint64(e.NowFunc().Unix())
 
 			messageMask := db.DBMessage{
 				ChainID: &chainID,

agents/agents/executor/executor_test.go

@@ -612,7 +612,7 @@ func (e *ExecutorSuite) TestExecutor() {
 	gasData := types.NewGasData(uint16(1), uint16(1), uint16(1), uint16(1), uint16(1), uint16(1))
 	originState := types.NewState(rootB32, chainID, nonce, big.NewInt(1), big.NewInt(1), gasData)
 	randomGasData := types.NewGasData(gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16())
-	randomState := types.NewState(common.BigToHash(big.NewInt(gofakeit.Int64())), chainID+1, gofakeit.Uint32(), big.NewInt(gofakeit.Int64()), big.NewInt(gofakeit.Int64()), randomGasData)
+	randomState := types.NewState(common.BigToHash(big.NewInt(int64(gofakeit.Int32()))), chainID+1, gofakeit.Uint32(), big.NewInt(int64(gofakeit.Int32())), big.NewInt(int64(gofakeit.Int32())), randomGasData)
 	originSnapshot := types.NewSnapshot([]types.State{originState, randomState})
 
 	snapshotRoot, proofs, err := originSnapshot.SnapshotRootAndProofs()
@@ -682,22 +682,22 @@ func (e *ExecutorSuite) TestSetMinimumTime() {
 		common.BigToHash(big.NewInt(gofakeit.Int64())),
 		chainID,
 		1,
-		big.NewInt(gofakeit.Int64()),
-		big.NewInt(gofakeit.Int64()),
+		big.NewInt(int64(gofakeit.Int32())),
+		big.NewInt(int64(gofakeit.Int32())),
 		types.NewGasData(gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16()))
 	state1 := types.NewState(
 		common.BigToHash(big.NewInt(gofakeit.Int64())),
 		chainID,
 		2,
-		big.NewInt(gofakeit.Int64()),
-		big.NewInt(gofakeit.Int64()),
+		big.NewInt(int64(gofakeit.Int32())),
+		big.NewInt(int64(gofakeit.Int32())),
 		types.NewGasData(gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16()))
 	state2 := types.NewState(
 		common.BigToHash(big.NewInt(gofakeit.Int64())),
 		chainID,
 		5,
-		big.NewInt(gofakeit.Int64()),
-		big.NewInt(gofakeit.Int64()),
+		big.NewInt(int64(gofakeit.Int32())),
+		big.NewInt(int64(gofakeit.Int32())),
 		types.NewGasData(gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16(), gofakeit.Uint16()))
 
 	snapshot0 := types.NewSnapshot([]types.State{state0})
@@ -992,7 +992,6 @@ func (e *ExecutorSuite) TestSendManagerMessage() {
 	txContext := e.TestBackendSummit.GetTxContext(e.GetTestContext(), e.SummitMetadata.OwnerPtr())
 	tx, err = e.SummitDomainClient.Inbox().SubmitSnapshot(
 		txContext.TransactOpts,
-		e.GuardUnbondedSigner,
 		encodedSnapshot,
 		guardSnapshotSignature,
 	)
@@ -1005,7 +1004,6 @@ func (e *ExecutorSuite) TestSendManagerMessage() {
 	e.Nil(err)
 	tx, err = e.SummitDomainClient.Inbox().SubmitSnapshot(
 		txContext.TransactOpts,
-		e.NotaryUnbondedSigner,
 		encodedSnapshot,
 		notarySnapshotSignature,
 	)