Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitter: bump MaxResultsPerChain to 10 #2651

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

dwasse
Copy link
Collaborator

@dwasse dwasse commented May 30, 2024

Summary by CodeRabbit

  • New Features
    • Increased the maximum number of transactions fetched per chain from 2 to 10.
    • Improved context propagation, tracing, and metrics handling in the transaction processing method.

@dwasse dwasse requested a review from trajan0x as a code owner May 30, 2024 15:41
Copy link
Contributor

coderabbitai bot commented May 30, 2024

Walkthrough

The recent changes include increasing the maximum number of transaction results per chain from 2 to 10 in the ethergo/submitter/db/txdb package. Additionally, the processDB method in the Relayer struct within the services/rfq/relayer/service package has been updated to include a parentCtx parameter for better context handling, along with enhancements for tracing and metrics collection.

Changes

File Path Change Summary
ethergo/submitter/db/txdb/store.go Increased MaxResultsPerChain constant from 2 to 10.
services/rfq/relayer/service/relayer.go Updated processDB method to include parentCtx parameter, added tracing, and metrics handling.

Poem

In the code where changes flow,
Transactions now can grow and grow. 🌱
From two to ten, they now expand,
Across the chains, a helping hand.
And with new context, metrics trace,
The relayer's pace, a steady grace. 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added go Pull requests that update Go code size/xs labels May 30, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 14d03f7 and b889f0d.

Files selected for processing (1)
  • ethergo/submitter/db/txdb/store.go (1 hunks)
Additional comments not posted (1)
ethergo/submitter/db/txdb/store.go (1)

70-70: Change in MaxResultsPerChain from 2 to 10.

Ensure that the system's performance metrics are monitored to assess the impact of this change, especially during peak loads.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 40.49664%. Comparing base (14d03f7) to head (4eda6cd).
Report is 2 commits behind head on master.

Files Patch % Lines
services/rfq/relayer/service/relayer.go 0.00000% 5 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #2651         +/-   ##
===================================================
- Coverage   41.43415%   40.49664%   -0.93752%     
===================================================
  Files            244         197         -47     
  Lines          17167       16068       -1099     
  Branches         312          80        -232     
===================================================
- Hits            7113        6507        -606     
+ Misses          9202        8727        -475     
+ Partials         852         834         -18     
Flag Coverage Δ
cctp-relayer 44.68619% <ø> (ø)
committee 62.20028% <ø> (-1.41045%) ⬇️
explorer 24.16714% <ø> (ø)
omnirpc 53.15110% <ø> (ø)
promexporter 75.91241% <ø> (?)
rfq 31.60465% <0.00000%> (-0.07599%) ⬇️
scribe 52.02703% <ø> (-0.18427%) ⬇️
sin-executor 63.56589% <ø> (+3.10077%) ⬆️
solidity ?
stiprelayer 3.33333% <ø> (ø)
tools 21.98661% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented May 30, 2024

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4eda6cd
Status: ✅  Deploy successful!
Preview URL: https://e8d90bc4.sanguine-fe.pages.dev
Branch Preview URL: https://feat-bump-submitter-results.sanguine-fe.pages.dev

View logs

@dwasse dwasse requested a review from aureliusbtc as a code owner May 31, 2024 15:47
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
services/rfq/relayer/service/relayer.go (1)

305-305: Consider adding more detailed logging or error messages to enhance observability and debugging capabilities further.

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b889f0d and 4eda6cd.

Files selected for processing (1)
  • services/rfq/relayer/service/relayer.go (1 hunks)
Additional comments not posted (1)
services/rfq/relayer/service/relayer.go (1)

300-305: The addition of parentCtx for context propagation and the integration of tracing and metrics handling are excellent improvements.

@dwasse dwasse merged commit 48e1015 into master Jun 4, 2024
67 of 70 checks passed
@dwasse dwasse deleted the feat/bump-submitter-results branch June 4, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant