-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submitter: bump MaxResultsPerChain to 10 #2651
Conversation
WalkthroughThe recent changes include increasing the maximum number of transaction results per chain from 2 to 10 in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- ethergo/submitter/db/txdb/store.go (1 hunks)
Additional comments not posted (1)
ethergo/submitter/db/txdb/store.go (1)
70-70
: Change inMaxResultsPerChain
from 2 to 10.Ensure that the system's performance metrics are monitored to assess the impact of this change, especially during peak loads.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2651 +/- ##
===================================================
- Coverage 41.43415% 40.49664% -0.93752%
===================================================
Files 244 197 -47
Lines 17167 16068 -1099
Branches 312 80 -232
===================================================
- Hits 7113 6507 -606
+ Misses 9202 8727 -475
+ Partials 852 834 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying sanguine-fe with
|
Latest commit: |
4eda6cd
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e8d90bc4.sanguine-fe.pages.dev |
Branch Preview URL: | https://feat-bump-submitter-results.sanguine-fe.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
services/rfq/relayer/service/relayer.go (1)
305-305
: Consider adding more detailed logging or error messages to enhance observability and debugging capabilities further.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- services/rfq/relayer/service/relayer.go (1 hunks)
Additional comments not posted (1)
services/rfq/relayer/service/relayer.go (1)
300-305
: The addition ofparentCtx
for context propagation and the integration of tracing and metrics handling are excellent improvements.
Summary by CodeRabbit