-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FE Release 2024-06-13 #2680
FE Release 2024-06-13 #2680
Changes from all commits
0ac20e8
1f3f85b
5c55e31
c5e3c32
b6158c4
be23318
b417645
7e27d9d
df0d899
36e77b4
972afed
c210cfc
a9762ea
8721ba0
48e1015
b7cb945
ebcc94c
d3be8a0
edb67ff
5de3ede
ab26028
86a2367
da59db6
f4dd0ad
356dfe6
1791615
9daff99
49f6477
8430f37
b5a499c
70be4cb
a9a6f84
7533f70
a0ac2e1
25894d2
3464c4e
370f8fe
d448263
2f45287
d79b82a
b87fb9f
7ee6bd2
30be8d6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,3 +129,4 @@ fastcache.tmp* | |
main | ||
.devnet/ | ||
|
||
**/__debug_bin* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
v18.17.0 | ||
v18.18.0 |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -602,7 +602,7 @@ func (g *GuardSuite) TestInvalidReceipt() { | |||||||
deliveryTip := big.NewInt(int64(gofakeit.Uint32())) | ||||||||
tips := types.NewTips(summitTip, attestationTip, executorTip, deliveryTip) | ||||||||
optimisticSeconds := uint32(1) | ||||||||
recipientDestination := g.TestClientMetadataOnDestination.Address().Hash() | ||||||||
recipientDestination := common.BytesToHash(g.TestClientMetadataOnDestination.Address().Bytes()) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure proper error handling for blockchain interactions. In the - Nil(g.T(), err)
+ require.Nil(g.T(), err, "Error should be nil during blockchain interaction") Committable suggestion
Suggested change
Refactor repeated code into helper functions. The + func submitSnapshot(ctx context.Context, snapshot types.Snapshot, signer signer.Signer) error {
+ guardSnapshotSignature, encodedSnapshot, _, err := snapshot.SignSnapshot(ctx, signer)
+ if err != nil {
+ return err
+ }
+ txContextSummit := g.TestBackendSummit.GetTxContext(ctx, g.InboxMetadataOnSummit.OwnerPtr())
+ tx, err := g.SummitDomainClient.Inbox().SubmitSnapshot(txContextSummit.TransactOpts, encodedSnapshot, guardSnapshotSignature)
+ if err != nil {
+ return err
+ }
+ g.TestBackendSummit.WaitForConfirmation(ctx, tx)
+ return nil
+ }
|
||||||||
nonce := uint32(1) | ||||||||
body := []byte{byte(gofakeit.Uint32())} | ||||||||
txContextOrigin := g.TestBackendOrigin.GetTxContext(g.GetTestContext(), g.OriginContractMetadata.OwnerPtr()) | ||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure proper handling of error after transaction submission.
It's important to handle the error returned by the
SendBaseMessage
function immediately after it's called. This ensures that any issues with the transaction are caught early and handled appropriately.Committable suggestion