Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE Release 2024-06-13 #2680

Merged
merged 43 commits into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
0ac20e8
optional settable poll interval (#2652)
trajan0x May 31, 2024
1f3f85b
poll interval increase (#2653)
trajan0x May 31, 2024
5c55e31
copy poll interval
trajan0x May 31, 2024
c5e3c32
poll interval fix
trajan0x May 31, 2024
b6158c4
cleanup verifier
trajan0x May 31, 2024
be23318
add hook to listener (#2654)
trajan0x Jun 1, 2024
b417645
make poll interval a setting (#2655)
trajan0x Jun 1, 2024
7e27d9d
update bl
aureliusbtc Jun 2, 2024
df0d899
feat(solidity-devops): environment-specific configs (#2658)
ChiTimesChi Jun 2, 2024
36e77b4
Publish
ChiTimesChi Jun 2, 2024
972afed
fix(solidity-devops): allow verifier fo be omitted for a chain (#2659)
ChiTimesChi Jun 2, 2024
c210cfc
Publish
ChiTimesChi Jun 2, 2024
a9762ea
Update bl
aureliusbtc Jun 4, 2024
8721ba0
update bl
aureliusbtc Jun 4, 2024
48e1015
Submitter: bump MaxResultsPerChain to 10 (#2651)
dwasse Jun 4, 2024
b7cb945
fix(solidity-devops): use npx to run the binaries
ChiTimesChi Jun 4, 2024
ebcc94c
fix(solidity-devops): update README (#2666)
ChiTimesChi Jun 4, 2024
d3be8a0
Publish
ChiTimesChi Jun 4, 2024
edb67ff
adding funding json to project root (#2665)
Defi-Moses Jun 5, 2024
5de3ede
FeePricer: use different multipliers for quote / relay (#2663)
dwasse Jun 5, 2024
ab26028
feat(synapse-interface): upgrade wagmi, viem, rainbowkit to support s…
bigboydiamonds Jun 5, 2024
86a2367
Publish
bigboydiamonds Jun 5, 2024
da59db6
Omnirpc: add module for receipt request backups (#2678)
dwasse Jun 6, 2024
f4dd0ad
port fix (#2679)
trajan0x Jun 6, 2024
356dfe6
Remove cypress github actions file (#2675)
bigboydiamonds Jun 6, 2024
1791615
fix(synapse-interface): rfq maps generation (#2681)
ChiTimesChi Jun 7, 2024
9daff99
Publish
ChiTimesChi Jun 7, 2024
49f6477
RFQ API: use prometheus gauge metrics (#2682)
dwasse Jun 8, 2024
8430f37
Submitter: don't bump transactions without sufficient gas (#2664)
dwasse Jun 8, 2024
b5a499c
Move Terraform to new repo (#2684)
trajan0x Jun 8, 2024
70be4cb
fix slither (#2687)
trajan0x Jun 8, 2024
a9a6f84
Publish
trajan0x Jun 8, 2024
7533f70
fix: adjust to #2658 breaking changes (#2688)
ChiTimesChi Jun 9, 2024
a0ac2e1
Publish
ChiTimesChi Jun 9, 2024
25894d2
Upgrade geth to 1.13 (#2416)
aureliusbtc Jun 9, 2024
3464c4e
fix(deps): update github.com/gen2brain/beeep digest to 9c00667 (#2669)
renovate[bot] Jun 9, 2024
370f8fe
fix(deps): update github.com/gocarina/gocsv digest to 78e41c7 (#2670)
renovate[bot] Jun 9, 2024
d448263
fix(deps): update github.com/vishalkuo/bimap digest to a9fb9b5 (#2683)
renovate[bot] Jun 9, 2024
2f45287
fix(deps): update github.com/kendru/darwin/go/depgraph digest to 4d1c…
renovate[bot] Jun 9, 2024
d79b82a
bulk update dependencies [goreleaser] (#2696)
trajan0x Jun 10, 2024
b87fb9f
update bl
aureliusbtc Jun 12, 2024
7ee6bd2
Removes boilerplate (#2725)
abtestingalpha Jun 13, 2024
30be8d6
Publish
abtestingalpha Jun 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
28 changes: 0 additions & 28 deletions .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,6 @@ flags:
paths:
- agents/
carryforward: true
committee:
paths:
- committee/
carryforward: true
sin-executor:
paths:
- sin-executor/
carryforward: true
screener-api:
paths:
- contrib/screener-api/
Expand All @@ -38,26 +30,6 @@ flags:
paths:
- contrib/git-changes-action/
carryforward: true
release-copier-action:
paths:
- contrib/release-copier-action/
carryforward: true
terraform-provider-helmproxy:
paths:
- contrib/terraform-provider-helmproxy/
carryforward: true
terraform-provider-iap:
paths:
- contrib/terraform-provider-iap/
carryforward: true
terraform-provider-kubeproxy:
paths:
- contrib/terraform-provider-kubeproxy/
carryforward: true
tfcore:
paths:
- contrib/tfcore/
carryforward: true
core:
paths:
- core/
Expand Down
3 changes: 0 additions & 3 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
"ghcr.io/devcontainers/features/github-cli:1": {
"version": "latest",
},
"ghcr.io/devcontainers/features/terraform:1": {
"version": "latest",
},
"ghcr.io/devcontainers/features/node:1": {
"version": "latest",
}
Expand Down
44 changes: 0 additions & 44 deletions .github/workflows/cypress.yml

This file was deleted.

6 changes: 3 additions & 3 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -523,18 +523,18 @@ jobs:
# Foundry is required for flattening
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
if: ${{ contains(matrix.package, 'agents') || contains(matrix.package, 'services/rfq') || contains(matrix.package, 'sin-executor') || contains(matrix.package, 'committee') }}
if: ${{ contains(matrix.package, 'agents') || contains(matrix.package, 'services/rfq') }}
with:
version: nightly

- name: Install Node Dependencies
run: yarn install --immutable
if: ${{ contains(matrix.package, 'agents') || contains(matrix.package, 'services/rfq') || contains(matrix.package, 'sin-executor') || contains(matrix.package, 'committee') }}
if: ${{ contains(matrix.package, 'agents') || contains(matrix.package, 'services/rfq') }}

# Generate flattened files
- name: Run flattener
run: npx lerna exec npm run build:go
if: ${{ contains(matrix.package, 'agents') || contains(matrix.package, 'services/rfq') || contains(matrix.package, 'sin-executor') || contains(matrix.package, 'committee') }}
if: ${{ contains(matrix.package, 'agents') || contains(matrix.package, 'services/rfq') }}

# Setup Go
- uses: actions/setup-go@v4
Expand Down
29 changes: 0 additions & 29 deletions .github/workflows/goreleaser-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -258,35 +258,6 @@ jobs:
name: ${{steps.project_id.outputs.project_name}}.zip
path: ${{steps.project_id.outputs.project_name}}.zip

- name: Copy Releases
if: ${{ steps.branch-name.outputs.is_default == 'true' && contains( steps.tag_version.outputs.new_tag, 'terraform-provider-iap') }}
uses: docker://ghcr.io/synapsecns/sanguine/release-copier-action:latest
with:
github_token: ${{ secrets.PUBLISH_TOKEN }}
# TODO: will change with new org
destination_repo: 'trajan0x/terraform-provider-iap'
tag_name: ${{ steps.tag_version.outputs.new_tag }}
strip_prefix: 'contrib/terraform-provider-iap/'

- name: Copy Releases
if: ${{ steps.branch-name.outputs.is_default == 'true' && contains( steps.tag_version.outputs.new_tag, 'terraform-provider-helmproxy') }}
uses: docker://ghcr.io/synapsecns/sanguine/release-copier-action:latest
with:
github_token: ${{ secrets.PUBLISH_TOKEN }}
# TODO: will change with new org
destination_repo: 'trajan0x/terraform-provider-helmproxy'
tag_name: ${{ steps.tag_version.outputs.new_tag }}
strip_prefix: 'contrib/terraform-provider-helmproxy/'

- name: Copy Releases
if: ${{ steps.branch-name.outputs.is_default == 'true' && contains( steps.tag_version.outputs.new_tag, 'terraform-provider-kubeproxy') }}
uses: docker://ghcr.io/synapsecns/sanguine/release-copier-action:latest
with:
github_token: ${{ secrets.PUBLISH_TOKEN }}
# TODO: will change with new org
destination_repo: 'trajan0x/terraform-provider-kubeproxy'
tag_name: ${{ steps.tag_version.outputs.new_tag }}
strip_prefix: 'contrib/terraform-provider-kubeproxy/'

- name: Refresh Report Card
if: steps.branch-name.outputs.is_default == 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Run ShellCheck
uses: ludeeus/action-shellcheck@master
with:
ignore_paths: ./contrib/terraform-provider-iap/scripts/add-tfmac.sh ./contrib/terraform-provider-helmproxy/scripts/add-tfmac.sh ./contrib/terraform-provider-kubeproxy/scripts/add-tfmac.sh ./contrib/scripts/txdecoder.sh
ignore_paths: ./contrib/scripts/txdecoder.sh

- name: Validate renovate
uses: rinchsan/renovate-config-validator@v0.0.12
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/solidity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@ on:
- 'packages/contracts-core/**'
- 'packages/contracts-rfq/**'
- '.github/workflows/solidity.yml'
- 'packages/contracts-communication/**'
- 'packages/solidity-devops/**'
push:
paths:
- 'packages/contracts-core/**'
- 'packages/contracts-rfq/**'
- 'packages/contracts-communication/**'
- 'packages/solidity-devops/**'
- '.github/workflows/solidity.yml'

Expand All @@ -39,7 +37,6 @@ jobs:
contracts-core: 'packages/contracts-core/**'
contracts-rfq: 'packages/contracts-rfq/**'
solidity-devops: 'packages/solidity-devops/**'
contracts-communication: 'packages/contracts-communication/**'
- id: length
run: |
export FILTER_LENGTH=$(echo $FILTERED_PATHS | jq '. | length')
Expand Down Expand Up @@ -83,7 +80,6 @@ jobs:
{
"contracts-core": "${{ secrets.VERCEL_CONTRACT_DOCS_PROJECT_ID}}",
"contracts-rfq": "${{ secrets.VERCEL_CONTRACT_RFQ_DOCS_PROJECT_ID }}",
"contracts-communication": "${{ secrets.VERCEL_COMMUNICATION_DOCS_PROJECT_ID }}",
"solidity-devops": "${{ secrets.VERCEL_DEVOPS_DOCS_PROJECT_ID }}"
}
END
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,4 @@ fastcache.tmp*
main
.devnet/

**/__debug_bin*
3 changes: 1 addition & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ run:
- grpc/client/rest/*
- bundle/*
- generated/*
- tracely/*
timeout: 15m
skip-files:
- '.*\\.abigen\\.go$'
Expand Down Expand Up @@ -135,4 +134,4 @@ issues:
- cyclop

exclude-use-default: false
new-from-rev: 5f8d480f4e3f1f2a318243a9924f50ec90ec4945
new-from-rev: a9a6f84f0569de877d06a027257aeca266aeda49
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.17.0
v18.18.0
11 changes: 2 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,22 +49,15 @@ There are a variety of different packages in this repo, covered comprehensively
<pre>
root
├── <a href="./agents">agents</a>: agents contain all the agents used in optimistic messaging
├── <a href="./committe">committe</a>: sin synapsemodule committee.
├── <a href="./charts">charts</a>: The helm charts used for deploying sanguine related services
├── <a href="./contrib">contrib</a>: Devops related tools
│ ├── <a href="./contrib/git-changes-action">git-changes-action</a>: Github action for identifying changes in dependent modules in a go workspace
│ ├── <a href="./contrib/promexporter">promexporter</a>: Multi-service prometheus exporter
│ ├── <a href="./contrib/screener-api">screener-api</a>: Optional address screening api
│ ├── <a href="./contrib/release-copier-action">release-copier-action</a>: Github action for copying releases from one repo to another
│ ├── <a href="./contrib/terraform-provider-iap">terraform-provider-iap</a>: Terraform provider used for bastion proxy tunneling
│ ├── <a href="./contrib/terraform-provider-helmproxy">terraform-provider-helmproxy</a>: Terraform provider that allows helm to be proxied through an iap bastion proxy
│ ├── <a href="./contrib/terraform-provider-kubeproxy">terraform-provider-kubeproxy</a>: Terraform provider that allows kube to be proxied through an iap bastion proxy
│ ├── <a href="./contrib/tfcore">tfcore</a>: Terraform core utilities + iap utilities
├── <a href="./core">core</a>: The Go core library with common utilities for use across the monorepo
├── <a href="./ethergo">ethergo</a>: Go-based ethereum testing + common library
├── <a href="./packages">packages</a>
│ ├── <a href="./packages/contracts-core">contracts-core</a>: Core contracts used for synapse, powered by <a href="https://github.com/foundry-rs/foundry">Foundry</a>
│ ├── <a href="./packages/contracts-core">contracts-communication</a>: SIN contracts.
│ ├── <a href="./packages/contracts-rfq">rfq</a>: RFQ contracts
│ ├── <a href="./packages/coverage-aggregator">coverage-aggregator</a>: Javascript coverage aggregator based on <a href="https://www.npmjs.com/package/nyc">nyc</a>
│ ├── <a href="./packages/docs">docs</a>: Docasaurus documentation. Note: this is not yet in use, and docs are still maintained on gitbook
Expand All @@ -82,14 +75,14 @@ root
│ ├── <a href="./services/rfq">rfq</a>: RFQ contracts
│ ├── <a href="./services/scribe">scribe</a>: Generalized ethereum event logger
│ ├── <a href="./services/omnirpc">omnirpc</a>: Latency aware RPC Client used across multiple-chains at once
├── <a href="./sin-executor">sin-executor</a>: synapse interchain execturo.
├── <a href="./tools">tools</a>
│ ├── <a href="./tools/abigen">abigen</a>: Used to generate abigen bindings for go
│ ├── <a href="./tools/bundle">bundle</a>: Modified version of <a href="https://pkg.go.dev/golang.org/x/tools@v0.5.0/cmd/bundle"> go bundler </a> with improved shadowing support
│ ├── <a href="./tools/modulecopier">module copier</a>: Used to copy internal modules and export methods for testing
│ ├── <a href="./tools/revertresolver">revertresolver</a>: Converts hexified solidity errors into their underlying errors.
</pre>

Note: Terraform related modules have been moved to [this repository](https://github.com/synapsecns/tf-providers)

## Setup

Clone the repository, open it, and install nodejs packages with `yarn`:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func (u *AgentsIntegrationSuite) TestAgentsE2E() {

tips := types.NewTips(big.NewInt(0), big.NewInt(0), big.NewInt(0), big.NewInt(0))
optimisticSeconds := uint32(1)
recipientDestination := u.TestClientMetadataOnDestination.Address().Hash()
recipientDestination := common.BytesToHash(u.TestClientMetadataOnDestination.Address().Bytes())
nonce := uint32(1)
body := []byte{byte(gofakeit.Uint32())}
txContextOrigin := u.TestBackendOrigin.GetTxContext(u.GetTestContext(), u.OriginContractMetadata.OwnerPtr())
Expand Down
2 changes: 1 addition & 1 deletion agents/agents/executor/executor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ func (e *ExecutorSuite) TestExecutor() {

optimisticSeconds := uint32(10)

recipient := testContractDest.Address().Hash()
recipient := common.BytesToHash(testContractDest.Address().Bytes())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure proper handling of error after transaction submission.

It's important to handle the error returned by the SendBaseMessage function immediately after it's called. This ensures that any issues with the transaction are caught early and handled appropriately.

- tx, err := e.OriginContract.SendBaseMessage(
+ tx, err := e.OriginContract.SendBaseMessage(
+ if err != nil {
+     return err
+ }
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
recipient := common.BytesToHash(testContractDest.Address().Bytes())
recipient := common.BytesToHash(testContractDest.Address().Bytes())
tx, err := e.OriginContract.SendBaseMessage(
if err != nil {
return err
}

nonce := uint32(1)
body := []byte{byte(gofakeit.Uint32())}

Expand Down
2 changes: 1 addition & 1 deletion agents/agents/guard/fraud_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ func (g *GuardSuite) TestInvalidReceipt() {
deliveryTip := big.NewInt(int64(gofakeit.Uint32()))
tips := types.NewTips(summitTip, attestationTip, executorTip, deliveryTip)
optimisticSeconds := uint32(1)
recipientDestination := g.TestClientMetadataOnDestination.Address().Hash()
recipientDestination := common.BytesToHash(g.TestClientMetadataOnDestination.Address().Bytes())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure proper error handling for blockchain interactions.

In the TestInvalidReceipt function, there are multiple blockchain interactions (SendBaseMessage, SubmitSnapshot, etc.) where errors are checked but not handled properly. It's crucial to handle these errors to avoid incorrect test passes and ensure robustness.

- Nil(g.T(), err)
+ require.Nil(g.T(), err, "Error should be nil during blockchain interaction")
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
recipientDestination := common.BytesToHash(g.TestClientMetadataOnDestination.Address().Bytes())
recipientDestination := common.BytesToHash(g.TestClientMetadataOnDestination.Address().Bytes())
require.Nil(g.T(), err, "Error should be nil during blockchain interaction")

Refactor repeated code into helper functions.

The TestUpdateAgentStatusOnRemote function contains repeated logic for submitting snapshots and attestations. Consider refactoring this into helper functions to improve code readability and maintainability.

+ func submitSnapshot(ctx context.Context, snapshot types.Snapshot, signer signer.Signer) error {
+     guardSnapshotSignature, encodedSnapshot, _, err := snapshot.SignSnapshot(ctx, signer)
+     if err != nil {
+         return err
+     }
+     txContextSummit := g.TestBackendSummit.GetTxContext(ctx, g.InboxMetadataOnSummit.OwnerPtr())
+     tx, err := g.SummitDomainClient.Inbox().SubmitSnapshot(txContextSummit.TransactOpts, encodedSnapshot, guardSnapshotSignature)
+     if err != nil {
+         return err
+     }
+     g.TestBackendSummit.WaitForConfirmation(ctx, tx)
+     return nil
+ }

Committable suggestion was skipped due to low confidence.

nonce := uint32(1)
body := []byte{byte(gofakeit.Uint32())}
txContextOrigin := g.TestBackendOrigin.GetTxContext(g.GetTestContext(), g.OriginContractMetadata.OwnerPtr())
Expand Down
Loading
Loading